Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression with v0.2.0 #5

Closed
zkochan opened this issue Sep 15, 2022 · 1 comment · Fixed by pnpm/pnpm#5360
Closed

Regression with v0.2.0 #5

zkochan opened this issue Sep 15, 2022 · 1 comment · Fixed by pnpm/pnpm#5360

Comments

@zkochan
Copy link
Member

zkochan commented Sep 15, 2022

@ibezkrovnyi if I update @pnpm/meta-updater in the pnpm monorepo and I run pnpm lint:meta, I get an error:

ERROR: undefined is not up-to-dateTypeError: Cannot read property 'split' of undefined
    at Diff.lineDiff.tokenize (/home/zoli/src/pnpm/pnpm-copy/node_modules/.pnpm/diff@4.0.2/node_modules/diff/lib/diff/line.js:43:32)
    at Diff.diff (/home/zoli/src/pnpm/pnpm-copy/node_modules/.pnpm/diff@4.0.2/node_modules/diff/lib/diff/base.js:45:39)
    at diffLines (/home/zoli/src/pnpm/pnpm-copy/node_modules/.pnpm/diff@4.0.2/node_modules/diff/lib/diff/line.js:68:19)
    at structuredPatch (/home/zoli/src/pnpm/pnpm-copy/node_modules/.pnpm/diff@4.0.2/node_modules/diff/lib/patch/create.js:48:3)
    at createTwoFilesPatch (/home/zoli/src/pnpm/pnpm-copy/node_modules/.pnpm/diff@4.0.2/node_modules/diff/lib/patch/create.js:224:14)
    at Object.createPatch (/home/zoli/src/pnpm/pnpm-copy/node_modules/.pnpm/diff@4.0.2/node_modules/diff/lib/patch/create.js:245:10)
    at unified (/home/zoli/src/pnpm/pnpm-copy/node_modules/.pnpm/print-diff@1.0.0/node_modules/print-diff/lib/unified.js:30:22)
    at printDiff (/home/zoli/src/pnpm/pnpm-copy/node_modules/.pnpm/print-diff@1.0.0/node_modules/print-diff/index.js:5:11)
    at printJsonDiff (file:///home/zoli/src/pnpm/pnpm-copy/node_modules/.pnpm/@pnpm+meta-updater@0.2.0/node_modules/@pnpm/meta-updater/lib/index.js:79:5)
    at default (file:///home/zoli/src/pnpm/pnpm-copy/node_modules/.pnpm/@pnpm+meta-updater@0.2.0/node_modules/@pnpm/meta-updater/lib/index.js:26:17)
@ibezkrovnyi
Copy link
Contributor

Raised PR pnpm/pnpm#5360 with the required changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants