Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stackoverflow error when installing #38

Open
OlshaMB opened this issue Jul 30, 2023 · 7 comments
Open

Stackoverflow error when installing #38

OlshaMB opened this issue Jul 30, 2023 · 7 comments
Labels
bug Something isn't working

Comments

@OlshaMB
Copy link

OlshaMB commented Jul 30, 2023

image
@OlshaMB
Copy link
Author

OlshaMB commented Jul 30, 2023

deps list:

"dependencies": {
    "@editorjs/editorjs": "^2.27.2",
    "@types/node": "20.4.5",
    "@types/react": "18.2.17",
    "@types/react-dom": "18.2.7",
    "autoprefixer": "10.4.14",
    "eslint": "8.46.0",
    "eslint-config-next": "13.4.12",
    "next": "13.4.12",
    "postcss": "8.4.27",
    "react": "18.2.0",
    "react-dom": "18.2.0",
    "tailwindcss": "3.3.3",
    "typescript": "5.1.6"
  }

nextjs 13 deps + editorjs

@anonrig
Copy link
Member

anonrig commented Jul 30, 2023

Thanks for the bug report. I'll try to add better diagnostics!

@anonrig anonrig added the bug Something isn't working label Jul 30, 2023
@OlshaMB
Copy link
Author

OlshaMB commented Jul 30, 2023

@anonrig Do you have any idea why the stackoverflow would happend when tokio futures are used?

@OlshaMB
Copy link
Author

OlshaMB commented Jul 30, 2023

They are effectively threads???

@anonrig
Copy link
Member

anonrig commented Jul 30, 2023

I'm seeing a different error in my content-addressable-store branch:

➜  bug-report git:(content-addressable-store) ✗ ../target/debug/pacquet install
thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: FileSystem(Os { code: 21, kind: IsADirectory, message: "Is a directory" })', crates/package_manager/src/commands/add.rs:95:10
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

@anonrig
Copy link
Member

anonrig commented Jul 30, 2023

I released v0.1.2. Can you check if the issue persists? https://www.npmjs.com/package/pacquet

@steveklabnik
Copy link
Collaborator

They are effectively threads???

Yes and no. But in this sense, they're the same: there's an amount of stack that they get, and they can overflow it. In theory, Rust + Tokio should be able to analyze the exact amount of stack needed, and do that, but with recursion, stuff gets a bit more wonky, and can lead to overflow, just like with threads.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants