From bf918d11707b9dd7b845cbc0d993856d4cf31ac7 Mon Sep 17 00:00:00 2001 From: Zoltan Kochan Date: Mon, 14 Nov 2022 01:11:19 +0200 Subject: [PATCH] fix: error that sometimes happen on projects with linked deps close #5327 close #5614 --- .changeset/mighty-waves-tan.md | 5 +++++ .changeset/poor-berries-yell.md | 5 +++++ packages/resolve-dependencies/src/resolveDependencies.ts | 2 +- 3 files changed, 11 insertions(+), 1 deletion(-) create mode 100644 .changeset/mighty-waves-tan.md create mode 100644 .changeset/poor-berries-yell.md diff --git a/.changeset/mighty-waves-tan.md b/.changeset/mighty-waves-tan.md new file mode 100644 index 00000000000..bc2c6920c6f --- /dev/null +++ b/.changeset/mighty-waves-tan.md @@ -0,0 +1,5 @@ +--- +"pnpm": patch +--- + +Fix an error that sometimes happen on projects with linked local dependencies [#5327](https://github.com/pnpm/pnpm/issues/5327). diff --git a/.changeset/poor-berries-yell.md b/.changeset/poor-berries-yell.md new file mode 100644 index 00000000000..c6ca71988dd --- /dev/null +++ b/.changeset/poor-berries-yell.md @@ -0,0 +1,5 @@ +--- +"@pnpm/resolve-dependencies": patch +--- + +Fix the nodeId in dependenciesTree for linked local packages. diff --git a/packages/resolve-dependencies/src/resolveDependencies.ts b/packages/resolve-dependencies/src/resolveDependencies.ts index a9c10d9d3b2..f78a3318f84 100644 --- a/packages/resolve-dependencies/src/resolveDependencies.ts +++ b/packages/resolve-dependencies/src/resolveDependencies.ts @@ -665,7 +665,7 @@ async function resolveDependenciesOfDependency ( if (resolveDependencyResult == null) return { resolveDependencyResult: null } if (resolveDependencyResult.isLinkedDependency) { - ctx.dependenciesTree[resolveDependencyResult.pkgId] = { + ctx.dependenciesTree[`link:${path.relative(ctx.lockfileDir, resolveDependencyResult.resolution.directory)}`] = { children: {}, depth: -1, installable: true,