changed-files-ignore-pattern option

[ibezkrovnyi]

pnpm already has option test-pattern, which already does filtration of packages with globs if only files matching to specified test-patterns were changed.

It would be great if pnpm had more generic option similar to Microsoft Lage's ignore option to filter out changed projects, where only specified files were changed.

  /** Which files to ignore when calculating scopes with --since */
  ignore: string[];

https://github.com/microsoft/lage/blob/6d6c6be3180ab10938b08a941fb4ed0e9ffa0394/src/types/ConfigOptions.ts#L30-L31

Use cases:

• ignore changes in root-level .gitlab-ci.yaml: ignore[]=.gitlab-ci.yaml (need to pass dot option to micromatch)
• ignore changes in CODEOWNERS in any folder: ignore[]=**/CODEOWNERS (or ignore[]=CODEOWNERS, but first looks more explicit)
• ignore changes in .github folder: ignore[]=.github (or ignore[]=.github/**, again - dot option is required)
• ignore changes in any markdown file: ignore[]=**/*.md (or ignore[]=*.md, but then there will be no way to specify only root-level files)
• ignore some technical folders, reports/logs/cache stored in git repository: ignore[]={**/scripts,**/reports,**/cache}
• ignore test stubs: ignore[]=test/react-*/**
• ignore test files: ignore[]=**/tests/**
• ignore tooling files: ignore[]=tooling/pipeline-scripts

This can be option ignore[] which expects array of globs, or it can be some advanced syntax for --filter (pnpm already is able to filter/exclude packages by folders, but currently it expects folder===package I think)

I think, it should be relative to the workspace root directory, so glob *.md matches root-level md files, glob tooling/pipeline-scripts matches root-level path /tooling/pipeline-scripts and **/tests matches directory tests in any folder including root-level.

[zkochan]

Sounds good but the setting should be probably more explicit. ignore is too short and vague

[ibezkrovnyi]

• ignore-files
• ignore-changed-files
• changed-files-to-ignore
  ?

[ibezkrovnyi]

@zkochan

1. one more name for option:

• changed-files-ignore-patterns (changedFilesIgnorePatterns) : string[]

2. It looks like main change in logic will be single line:
   

   pnpm/packages/filter-workspace-packages/src/getChangedPackages.ts

   Line 66 in 632a9e2

   const changedFiles = diff.split('\n')

It should be replaced with:

  const changedFiles = micromatch.not(diff.split("\n"), changedFilesIgnorePatterns, {
    dot: true,
  });

3. Will you accept PR?

Could you please let me know what do you think about the above?

[zkochan]

Probably changed-files-ignore-pattern to make it similar to test-pattern

I am ok with this change. You will probably also need to add the new setting to @pnpm/config.