Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making independent-leaves=true by default in pnpm@4 #1040

Closed
zkochan opened this issue Feb 10, 2018 · 1 comment
Closed

Making independent-leaves=true by default in pnpm@4 #1040

zkochan opened this issue Feb 10, 2018 · 1 comment

Comments

@zkochan
Copy link
Member

zkochan commented Feb 10, 2018

As discussed in #1001, having not just the raw package files but also its dependencies in the store would make installations super fast.

However, some packages rely on their location, so it might be a big breaking change to move packages out of project/node_modules to the global store. To make the migration less painful, I suggest moving only packages with no dependencies to the store. We already have a config for that called independent-leaves. This change would not require changes in the shrinkwrap.yaml format.

So in pnpm@2 we would turn on independent-leaves by default. It will make installations approximately 8% faster. In pnpm@3 we would do #1001 and move all packages with their dependencies to the global store. It will require breaking changes in the shrinkwrap.yaml format


This should work only with packages that don't have to be built

@zkochan zkochan added this to the v2.0.0 milestone Feb 10, 2018
@zkochan zkochan modified the milestones: v2.0.0, v3.0.0 Mar 29, 2018
@zkochan zkochan removed this from the v3.0.0 milestone Sep 10, 2018
@zkochan zkochan changed the title Making independent-leaves=true by default in pnpm@2 Making independent-leaves=true by default in pnpm@3 Dec 6, 2018
@zkochan
Copy link
Member Author

zkochan commented Jan 5, 2019

This may cause issues with packages that use optional peer dependencies. We should support #1486

@zkochan zkochan changed the title Making independent-leaves=true by default in pnpm@3 Making independent-leaves=true by default in pnpm@4 Apr 8, 2019
@zkochan zkochan closed this as completed Jan 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant