Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lifecycle script not called before symlinking bin file when another package in the workspace depends on it. #1864

Closed
anuraaga opened this issue Jun 5, 2019 · 1 comment

Comments

@anuraaga
Copy link

anuraaga commented Jun 5, 2019

pnpm version: 3.4.1

Code to reproduce the issue:

Uploaded to https://github.com/anuraaga/pnpm-bin-lifecycle

$ git clone https://github.com/anuraaga/pnpm-bin-lifecycle
$ cd pnpm-bin-lifecycle
$ pnpm recursive install

Expected behavior:

Installs correctly

Actual behavior:

Install fails with unable to find file error

Scope: all 2 workspace packages
 ERROR  ENOENT: no such file or directory, lstat 'C:\tools\msys64\home\Anuraag\git\pnpm-bin-lifecycle\package1\build'

Additional information:

The bin script that pnpm is trying to find is created by package1's lifecycle script, however it seems that this is happening before the lifecycle has run. This seems to only happen when another package in the workspace depends on it, so in this case because package2 depends on package1, and package1 has a bin filecreated by a lifecycle script, it seems to fail.

@anuraaga
Copy link
Author

anuraaga commented Jun 5, 2019

Sorry for the noise, I found this is a dupe of #1801

@anuraaga anuraaga closed this as completed Jun 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant