Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for package.jsonc ? #3028

Open
JasonKleban opened this issue Dec 16, 2020 · 1 comment
Open

Add support for package.jsonc ? #3028

JasonKleban opened this issue Dec 16, 2020 · 1 comment

Comments

@JasonKleban
Copy link

VSCode doesn't support .json5 natively (yet?) and json5's lack of quoted key requirement seems to be incompatible with jsonc. I'd like VSCode to support json5, but in case that doesn't get traction, I'll ask here too.

Also, .jsonc extension should be preferred over .json (as should yaml and json5). (See #3027) Or there should be a workspace-specific pnpm-specific setting to pick it?

@DrSensor
Copy link

DrSensor commented Apr 3, 2021

Most of the tools that read tsconfig.json (e.g tsc, esbuild, ...) support comment and trailing comma. It's identified as JSON with comment (jsonc) If you open it with VSCode. Maybe it's good idea to borrow that 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants