Path in registry URL no longer respected if it does not end with a trailing slash

[aholtkamp]

pnpm version: 6.23.x

Code to reproduce the issue:

pnpm config set registry https://some.company.com/some-registry
pnpm install

Expected behavior:

The path "some-registry" is respected.

Actual behavior:

The path "some-registry" is ignored

Additional information:

Caused by #4032

This is an undocumented breaking change in a minor version update leading to not being able to upgrade pnpm in our company without adjusting our CI.

[zkochan]

I did not consider it to be a breaking because I was trying to make pnpm process the registry configuration the same way as the npm CLI does it. So I guess your current configuration doesn't work with npm as well? Could you check if it works with npm CLI?

[zkochan]

I have downgraded latest to 6.23.1 for now.

[zkochan]

@aholtkamp what exactly is the problem? What error do you get? Are the requests going to the wrong URL or is this an auth error? How do you set the auth token?

[aholtkamp]

Thanks for the quick response!
We recently switched from a (very buggy) npm 7 to pnpm and always provided the registry without a trailing slash. I double checked this using npm 7.x and it still works.

Regarding the question what the actual error is: When setting e.g. https://some.company.com/some-registry I get the error that my packages cannot be found below https://some.company.com/some-package/. Before 6.23.x the packages very correctly looked up below https://some.company.com/some-registry/some-package/

[zkochan]

ok, I think this PR should fix it: #4053

[zkochan]

Do the entries in your lockfile look like this

pnpm/pnpm-lock.yaml

Lines 9313 to 9316 in 8a99a01

	/get-npm-tarball-url/2.0.3:
	resolution: {integrity: sha512-R/PW6RqyaBQNWYaSyfrh54/qtcnOp22FHCCiRhSSZj0FP3KQWCsxxt0DzIdVTbwTqe9CtQfvl/FPD4UIPt4pqw==}
	engines: {node: '>=12.17'}
	dev: false

Or does the "resolution" field contain more fields?

[aholtkamp]

Our pnpm-lock.yaml is quite big but flying over the entries it looks like the "resolution" field does only contain "integrity" like in your example.

[zkochan]

In that case probably my pull request won't help. I have found an issue but only when the lockfile's resolution fields contain the "tarball" field.

[zkochan]

Try 6.23.4. It is not latest, so you'll need to explicitly install it.

[aholtkamp]

I have upgraded to 6.23.4 but it didn't fix the issue.

[zkochan]

it should work with 6.23.5

[zkochan]

@aholtkamp could you verify the fix in the latest version of pnpm?

[aholtkamp]

I can confirm that 6.23.5 works, thanks!

[zkochan]

I think I know what caused the regression in my change. Try pnpm v6.23.7-202112041634

[aholtkamp]

v6.23.7-202112041634 also works for us