Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Injected workspace peer dependency error (7.0.0-rc.2 - strict-peer-dependencies) #4529

Closed
PabloSzx opened this issue Apr 4, 2022 · 0 comments · Fixed by #4540
Closed

Injected workspace peer dependency error (7.0.0-rc.2 - strict-peer-dependencies) #4529

PabloSzx opened this issue Apr 4, 2022 · 0 comments · Fixed by #4540
Assignees
Milestone

Comments

@PabloSzx
Copy link
Member

PabloSzx commented Apr 4, 2022

pnpm version:

7.0.0-rc.2

Code to reproduce the issue:

https://github.com/PabloSzx/injected-workspace-peer-pnpm

{
  "name": "a",
  "version": "0.0.1",
  "devDependencies": {
    "b": "workspace:^0.0.1"
  },
  "peerDependencies": {
    "b": "workspace:^0.0.1"
  }
}
{
  "name": "b",
  "version": "0.0.1"
}
{
  "name": "c",
  "version": "0.0.1",
  "dependencies": {
    "a": "workspace:^0.0.1"
  },
  "devDependencies": {
    "b": "workspace:^0.0.1"
  },
  "dependenciesMeta": {
    "a": {
      "injected": true
    }
  }
}
pnpm -v
7.0.0-rc.2
pnpm update -r
Scope: all 3 workspace projects
 ERR_PNPM_PEER_DEP_ISSUES  Unmet peer dependencies

packages/c
└─┬ a
  └── ✕ unmet peer b@workspace:^0.0.1: found 0.0.1

Expected behavior:

To ignore the "workspace:" for the peer dependency version validation

Actual behavior:

Breaks because of the "workspace:" syntax

Additional information:

I had to do pnpm add -D b --strict-peer-dependencies=false just to be able to add "b" as dev dep

  • node -v prints: v16.14.0
  • Windows, macOS, or Linux?: macOS
@zkochan zkochan added this to the v7.0 milestone Apr 4, 2022
@zkochan zkochan self-assigned this Apr 5, 2022
zkochan added a commit that referenced this issue Apr 8, 2022
zkochan added a commit that referenced this issue Apr 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants