Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error happens when adding new deps in a workspace that has patches #4954

Closed
zkochan opened this issue Jun 29, 2022 · 2 comments · Fixed by #4956
Closed

Error happens when adding new deps in a workspace that has patches #4954

zkochan opened this issue Jun 29, 2022 · 2 comments · Fixed by #4956

Comments

@zkochan
Copy link
Member

zkochan commented Jun 29, 2022 

$ pnpm -v
7.4.0

patch is working great, thanks! But everytime I add new dependencies with pnpm add <pkg> I have this message:

Screenshot 2022-06-29 at 23 28 35

My package.json:

"pnpm": {
  "patchedDependencies": {
    "@babel/plugin-transform-typescript@7.18.6": "patches/@babel__plugin-transform-typescript@7.18.6.patch"
   }
}

I have to manually remove the patchedDependencies and put it back when I'm done. Am I doing right ?

Originally posted by @hrasoa in #3077 (comment)
@Jack-Works
Copy link
Member

I believe this is the same problem I've reported in #4945 (comment)

zkochan added a commit that referenced this issue Jun 30, 2022
@zkochan
fix: partial install in workspace with patches should not fail
660d2b3 
close #4954
@zkochan zkochan mentioned this issue Jun 30, 2022
Merged
zkochan added a commit that referenced this issue Jun 30, 2022
@zkochan
fix: partial install in workspace with patches should not fail (#4956)
5e0e7f5 
close #4954
@hrasoa
Copy link

hrasoa commented Jul 2, 2022 •
edited by zkochan

Nice one very quick! pnpm add is fixed, but I have the same error on pnpm remove though:

Screenshot 2022-07-02 at 10 11 06

zkochan added a commit that referenced this issue Jul 2, 2022
@zkochan
fix: don't fail when removing a dep from a workspace that has patches
0b38ec8 
ref #4954 (comment)
zkochan added a commit that referenced this issue Jul 2, 2022
@zkochan
fix: don't fail when removing a dep from a workspace that has patches
ff70619 
ref #4954 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: partial install in workspace with patches should not fail pnpm/pnpm
3 participants
@hrasoa @zkochan @Jack-Works