When using link-workspace-packages = deep, partially filtered installation does not fully install all dependencies

[kenrick95]

pnpm version: 7.5.1

Also used 6.32.25 and issue exist too

Code to reproduce the issue:

Scenario:

In a monorepo, there are two packages: G & F

• Package G has dependency on an external package E.
• External package E has dependency on package F.
• E, G, F are all published in registry

In that monorepo, we set link-workspace-packages = deep

This causes pnpm install to make E depends on internal version of F.

However if subsequently we clean the repo (remove all the node_modules) and we run pnpm install --filter G...", the dependencies of local version of F is not installed.

Repro here: https://github.com/kenrick95/pnpm-testing-repro-deep-install-issue

Expected behavior:

In that scenario, F's dependencies (direct & indirect too) are installed

Actual behavior:

F's dependencies are not installed

Additional information:

• node -v prints: 14.19.0
• Windows, macOS, or Linux?: macOS

[kenrick95]

Apologies for not verifying the fix, however seems like this is not totally fixed yet by that PR: #5220

That PR makes @pnpm/headless able to include missing project ids:

pnpm/pkg-manager/headless/src/index.ts

Line 283 in 0d65d62

const missingIds = importerIds.filter((importerId) => !initialImporterIdSet.has(importerId))

However, opts.allProjects received here is the filtered project list, not the whole workspace projects

pnpm/pkg-manager/headless/src/index.ts

Line 285 in 0d65d62

for (const project of Object.values(opts.allProjects)) {

The unit test of @pnpm/headless is passing because we are passing the all workspace projects to the headlessInstall function.

As I understand, when @pnpm/main calls @pnpm/core, it is passing the full workspace projects info at opts.allProjects, however when calling @pnpm/headlesss' headlessInstall, it is no longer the full workspace projects, but only the filtered ones