You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This will actually modify the workspace lock file, which will cause a failure in an CI env, due to the default behavior of the frozen lock file. Even without a frozen lock file, I believe that the deploy command should not change the workspace lock file. Or at least reset it to its original state once the deployment command is complete. Or am I wrong?
pnpm version: 7.5.2
Code to reproduce the issue:
This will work in any workspace linking a package with another one with workspace:*.
Hey, I think this wasn't thought through:
https://github.com/pnpm/pnpm/blob/main/packages/plugin-commands-deploy/src/deploy.ts#L101
This will actually modify the workspace lock file, which will cause a failure in an CI env, due to the default behavior of the frozen lock file. Even without a frozen lock file, I believe that the deploy command should not change the workspace lock file. Or at least reset it to its original state once the deployment command is complete. Or am I wrong?
pnpm version:
7.5.2
Code to reproduce the issue:
This will work in any workspace linking a package with another one with
workspace:*
.https://github.com/TheNoim/pnpm-deploy-bug-2
Expected behavior:
I expect that I can use the deploy command in a CI environment.
Actual behavior:
The deploy command tries to alter the lock file and fails due to CI constraints.
Additional information:
node -v
prints:v16.15.1
macOS 12.4 (21F79) on Apple Silicon
The text was updated successfully, but these errors were encountered: