Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

devDependencies should be injected when using the deploy command #5078

Closed
kilbiller opened this issue Jul 21, 2022 · 1 comment · Fixed by #5084
Closed

devDependencies should be injected when using the deploy command #5078

kilbiller opened this issue Jul 21, 2022 · 1 comment · Fixed by #5084
Assignees
@zkochan
Labels
area: deploy type: bug
Milestone
v7.7

Comments

@kilbiller
Copy link

pnpm version:

7.6.0

Expected behavior:

Local devDependencies of a workspace should be injected just the same as dependencies.
When copying between stages of a multi-stage docker build we can't have symlinked dependencies because they won't exist in the new stage and since we can deploy devDepencies since v7.6.0 they should be injected too.

Actual behavior:

Only dependencies are injected when using the deploy command.

Additional information:

  • node -v prints: v16.16.0
  • Windows, macOS, or Linux?: linux
@kilbiller kilbiller changed the title devDepencies should be injected when using the deploy command devDependencies should be injected when using the deploy command Jul 21, 2022
@zkochan zkochan self-assigned this Jul 23, 2022
zkochan added a commit that referenced this issue Jul 23, 2022
@zkochan
fix(deploy): inject all types of deps
0dc9e44 
close #5078
@zkochan zkochan mentioned this issue Jul 23, 2022
Merged
zkochan added a commit that referenced this issue Jul 23, 2022
@zkochan
fix(deploy): inject all types of deps (#5084)
107d011 
close #5078
@kilbiller
Copy link
Author

Thanks !

@zkochan zkochan added this to the v7.7 milestone Jul 27, 2022
@matzeeable matzeeable mentioned this issue Aug 26, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zkochan zkochan

Labels
area: deploy type: bug
Projects
None yet
Milestone
v7.7
Development

Successfully merging a pull request may close this issue.

fix(deploy): inject all types of deps pnpm/pnpm
2 participants
@zkochan @kilbiller