Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lockfile assembly: pnpm install --merge-git-branch-lockfiles does not update main lockfile #5212

Closed
kenrick95 opened this issue Aug 16, 2022 · 2 comments 路 Fixed by #5233
Closed
Milestone

Comments

@kenrick95
Copy link
Member

Trying #4475

Note: git-branch-lockfile is the config to set in .npmrc, not use-git-branch-lockfile (as described in the release notes) 馃槄

pnpm version: 7.9.0

Code to reproduce the issue:

https://github.com/kenrick95/pnpm-try-lockfile-assembly

Run pnpm install --merge-git-branch-lockfiles

Expected behavior:

  • pnpm-lock.feature-1.yaml is deleted
  • pnpm-lock.yaml is updated

Actual behavior:

  • pnpm-lock.feature-1.yaml is deleted
  • pnpm-lock.yaml is not updated

Additional information:

  • node -v prints: 14.19.3
  • Windows, macOS, or Linux?: MacOS 11.6.7
@kenrick95
Copy link
Member Author

cc @chengcyber

@chengcyber
Copy link
Member

Thanks for your feedback and the sweat reproduce repo! I will check this issue.

zkochan pushed a commit that referenced this issue Aug 18, 2022
* fix: mergeGitBranchLockfiles when merged lockfile is up-to-date

* chore: test install with --merge-git-branch-lockfiles when merged lockfile is up to date

* chore: changeset

* chore: test add also frozenLockfile: true+

close #5212

Co-authored-by: Cheng Liu <liucheng.leo@bytedance>
Co-authored-by: Cheng Liu <chengcyber@users.noreply.github.com>
@zkochan zkochan added this to the v7.9 milestone Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants