Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pnpm installs incorrect peer dependency version with no warning #5373

Closed
andershessellund opened this issue Sep 19, 2022 · 1 comment · Fixed by #5377
Closed

pnpm installs incorrect peer dependency version with no warning #5373

andershessellund opened this issue Sep 19, 2022 · 1 comment · Fixed by #5377
Assignees
Milestone

Comments

@andershessellund
Copy link

pnpm version:

7.12.0

Code to reproduce the issue:

I have a project with the following package.json:

{
  "peerDependencies": {
    "@angular/core": "13.3.6",
    "rxjs": "6.6.7"
  }
}

I add auto-install-peers=true to .npmrc.

@angular/core has a peer dependency on rxjs: "rxjs": "^6.5.3 || ^7.4.0"

Thus, the rxjs version specified in my package.json is compatible with the version specified by @angular/core.

Expected behavior:

I would expect to get the dependencies I specified. If this is not possible for some reason I cannot quite understand, I would expect to get a warning that pnpm was unable to resolve my dependencies.

Actual behavior:

I get rxjs version 7.5.6 . I do not get any warning that the installed dependency does not the version i specified.

Additional information:

Node v18.8.0 , running on Mac.

@zkochan
Copy link
Member

zkochan commented Sep 19, 2022

Looks like a regression in v7.12 via #5359

@zkochan zkochan changed the title PNPM installs incorrect peer dependency version with no warning pnpm installs incorrect peer dependency version with no warning Sep 19, 2022
@zkochan zkochan self-assigned this Sep 19, 2022
@zkochan zkochan added this to the v7.12 milestone Sep 19, 2022
zkochan added a commit that referenced this issue Sep 19, 2022
zkochan added a commit that referenced this issue Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants