Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filed tarball publishing returns a non-zero exit code #5396

Closed
soundstep opened this issue Sep 23, 2022 · 2 comments · Fixed by #5667
Closed

Filed tarball publishing returns a non-zero exit code #5396

soundstep opened this issue Sep 23, 2022 · 2 comments · Fixed by #5667
Milestone

Comments

@soundstep
Copy link

Publishing a tarball (not a package) that has been created with pnpm pack to a private repositiry with failed credentials should return a non-zero exit code, it currently returns a 0 exit code.

pnpm version:

7.12.1

Code to reproduce the issue:

Publish to any repo with failed credentials (or any publishing failure):

pnpm publish my-package-11.0.0.tgz --no-git-checks --registry "http://my-private-repo.com"

The expected error:

npm ERR! code E401
npm ERR! Unable to authenticate, your authentication token seems to be invalid.

The Issue ()this should be a non-zero exit code:

echo $?

Expected behavior:

Get a non-zero exit code from a failed tarball publishing.

Actual behavior:

Get a zero exit code from a failed tarball publishing.

Additional information:

  • node -v prints:
v14.20.0
  • Windows, macOS, or Linux?:
MacOS Monterey (12.1)
@soundstep
Copy link
Author

cc @jjoynson-iw

@ongshane
Copy link

Bump - we are also seeing this causing automation pipelines to fail silently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants