Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overrides with relative local paths(link:) points to invalid paths #5443

Closed
giuseppelt opened this issue Oct 3, 2022 · 3 comments · Fixed by #5475
Closed

Overrides with relative local paths(link:) points to invalid paths #5443

giuseppelt opened this issue Oct 3, 2022 · 3 comments · Fixed by #5475
Assignees
Milestone

Comments

@giuseppelt
Copy link

With the last version 7.13 pnpm overrides with relative linked path are broken.
It works fine with 7.12.1

The calculated relative paths don't start from the root.
It's resolved from somewhere deep in the tree(actual behavior=wrong), and not from the root (previous behavior=right).

pnpm version:

7.13

Code to reproduce the issue:

{
  "pnpm": {
     "overrides": {
          "PACKAGE:" : "link: ../../path/to/disk"
     }
  }
}

Expected behavior:

Linked location resolved from the root

Actual behavior:

Wrong location linked

Additional information:

node16
Windows

@zkochan
Copy link
Member

zkochan commented Oct 9, 2022

@lvqq did your changes break it?

@lvqq
Copy link
Member

lvqq commented Oct 10, 2022

I think it's not from my changes, I just update the read of link --global from cwd to --dir option or cwd

@zkochan zkochan self-assigned this Oct 10, 2022
@zkochan
Copy link
Member

zkochan commented Oct 10, 2022

Looks like it stopped working after this PR: #5403

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants