Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Installation in monorepos is not working since 7.11 #5454

Closed
matteobruni opened this issue Oct 5, 2022 · 3 comments · Fixed by #5467
Closed

[Bug] Installation in monorepos is not working since 7.11 #5454

matteobruni opened this issue Oct 5, 2022 · 3 comments · Fixed by #5467
Assignees
Milestone

Comments

@matteobruni
Copy link

pnpm version:

7.13.1

Code to reproduce the issue:

No code to show.

You can see the issue in this GitHub workflow clearly:

https://github.com/matteobruni/tsparticles/actions/runs/3188469288/jobs/5201173295

And this is the previous one that was working:

https://github.com/matteobruni/tsparticles/actions/runs/3182847410/jobs/5189320560

What's changed? I updated pnpm from 7.11.0 to 7.13.1, same problem affected 7.12.x as well.

Expected behavior:

Running pnpm install in a monorepo must install everything, like in 7.11.0.

Actual behavior:

pnpm install is not creating node_modules folder, making the monorepo unusable.

Additional information:

  • node -v prints: v16.17.0
  • Windows, macOS, or Linux?: macOS and Linux

Since this bug is blocking, my repository will be reverted to 7.11.0, that's why I linked the GitHub actions executions. You can try yourself cloning the repository and running pnpm install to see the issue.

These are the steps that should work, at least with 7.11.0 are working:

  • run: pnpm install --no-frozen-lockfile
  • run: pnpm run --filter @tsparticles/build build:ci
  • run: pnpm install --no-frozen-lockfile
  • run: npx lerna run build:ci

Another minor issue can be seen here as well, I have to run two different installs because the CLI command coming from the @tsparticles/build package, that is part of the monorepo, is not being recognized until I execute another install. It's frustrating, but at least is not blocking.

@matteobruni matteobruni changed the title Installation in monorepos is not working since 7.11 [Bug] Installation in monorepos is not working since 7.11 Oct 5, 2022
@zkochan zkochan self-assigned this Oct 5, 2022
@zkochan
Copy link
Member

zkochan commented Oct 6, 2022

Using your repo I was able to create a smaller workspace that reproduces the issue: https://github.com/zkochan/pnpm-issue-5454

@unional
Copy link

unional commented Oct 6, 2022

Have experience this for a while. Have to do pnpm i --force every time, probably related to #5427

image

☝️ you can see after pnpm i, the keyboard package still missing node_modules

@unional
Copy link

unional commented Oct 6, 2022

IMO this is very significant because it basically removes any performance benefits pnpm brings. How we have to run pnpm i --force every time we change the dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants