Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pnpm -r publish never fails or stop when the inner command exits with a non-zero code #5528

Closed
gao-sun opened this issue Oct 20, 2022 · 0 comments · Fixed by #6248
Closed

Comments

@gao-sun
Copy link

gao-sun commented Oct 20, 2022

pnpm version: 7.13.5

Code to reproduce the issue: pnpm -r publish

Expected behavior: fails when the inner command exits with a non-zero code

Actual behavior: continue publish

Additional information:

  • node -v prints: tried on both v16.15.0 and v18.8.0
  • Windows, macOS, or Linux?: macOS, Linux

Screenshot

image

I changed .npmrc to make it fail on purpose. as you can see the publish process is moving forward instead of ending with a non-zero code. looks like the code in recursivePublish.ts doesn't handle the situation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant