New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pnpm rebuild
not working when node-linker=hoisted
#5560
Comments
Looks like the rebuild command can only lookup packages inside the pnpm/packages/plugin-commands-rebuild/src/implementation/index.ts Lines 273 to 280 in b234923
Why do you need the rebuild command at all? The deps are built on |
Electron builder makes use of this rebuild command to rebuild the native dependency for different arch. Due to this issue, for all arch (amd64, arm64) the native dependency are compiled to only to one (amd64). |
pnpm version:
pnpm - 7.14.0
Code to reproduce the issue:
https://github.com/balajiv113/pnpm-test
Expected behavior:
pnpm rebuild should build native modules even when node-linker=hoisted
Actual behavior:
pnpm rebuild not running as expected node-linker=hoisted
Additional information:
Due to this issue, we are not able to do build electron application using electron-builder for multiple architectures (generating arm apps in intel and vice-versa). The app gets built, but the native binaries are on wrong architecture
The text was updated successfully, but these errors were encountered: