Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An error occurred while uploading (7.19.0) #5823

Closed
shirotech opened this issue Dec 22, 2022 · 8 comments
Closed

An error occurred while uploading (7.19.0) #5823

shirotech opened this issue Dec 22, 2022 · 8 comments
Assignees

Comments

@shirotech
Copy link
Contributor

pnpm version:

7.19.0

Code to reproduce the issue:

pnpm install

Expected behavior:

install without issues

Actual behavior:

pnpm complains about certain random packages e.g. core-js "An error occurred while uploading" then hangs

After reverting back to and older version, install works fine.

@shirotech shirotech changed the title Unable to upload in 7.19.0 An error occurred while uploading (7.19.0) Dec 22, 2022
@zkochan
Copy link
Member

zkochan commented Dec 22, 2022

Could you share repo that reproduces the issue? Do you use node-linker=hoisted?

@shirotech
Copy link
Contributor Author

Could you share repo that reproduces the issue? Do you use node-linker=hoisted?

Hi, yes I am using that option, here is complete list:

git-checks=false
node-linker=hoisted
include-workspace-root=true
link-workspace-packages=deep
install-links=true
ignore-workspace-root-check=true
package-import-method=hardlink
strict-peer-dependencies=false

It seems like you know what the cause is, otherwise I'll need some time to pinpoint what is causing the issue for the repro. Thank you.

@zkochan
Copy link
Member

zkochan commented Dec 23, 2022

I assume that this was caused by this change: #5814

But I don't know how to reproduce the issue.

@chungweileong94
Copy link

I'm getting the same error with the recent update. I'm suspecting that it might be caused by running pnpm i on an external drive. Will double-check that to see if it's true.

@chungweileong94
Copy link

I'm getting the same error with the recent update. I'm suspecting that it might be caused by running pnpm i on an external drive. Will double-check that to see if it's true.

Apparently, it was not the case, however, the problem start to happen if one/more of the packages are having postinstall script.

@chungweileong94
Copy link

Just realized it happens on Vercel deployment as well😕
image

@shirotech
Copy link
Contributor Author

@zkochan I saw the fix, and it seems to have removed the error/warning, but symptoms remains, now the postinstall still hangs as before:

node_modules/core-js: Running postinstall script, done in 88ms
node_modules/pngquant-bin: Running postinstall script, done in 525ms
Progress: resolved 994, reused 973, downloaded 0, added 3, done


^C

had to ctrl+c, CPU was full throttled and laptop was overheating, I assume there is infinite loop somewhere.

@zkochan
Copy link
Member

zkochan commented Jan 14, 2023

Try to add core-js to neverBuiltDependencies.

Also, it would help if you could provide a repo the reproduces the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants