Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy ignores files list of local dependencies #5911

Closed
microwavekonijn opened this issue Jan 10, 2023 · 1 comment · Fixed by #6016
Closed

Deploy ignores files list of local dependencies #5911

microwavekonijn opened this issue Jan 10, 2023 · 1 comment · Fixed by #6016

Comments

@microwavekonijn
Copy link

pnpm version: 7.24.0

Code to reproduce the issue:

pnpm-workspace.yml

packages:
  - 'a'
  - 'b'

a/package.json

{
  "dependencies": {
    "b": "workspace:*"
  }
}

b/package.json

{
  "files": ["included.js"]
}

b/included.js & b/not-included.js

Expected behavior:

When running deploy for a the local dependecy b only to include included.js.

Actual behavior:

All files of b are copied(i.e. b/not-included.js).

@dlemburg
Copy link

I came here looking to see if anyone had filed this issue. Been considering a variety of workarounds, including:

  • writing a script which removes not-included.js, etc
  • using the deprecated make-dedicated-lockfile -> pnpm i
  • using pnpm pack to create a package.json without workspace protocol and then write a script to update the appropriate lockfile entries. this seems like a bad idea, but we're doing something similar with yarn right now, so 🤷

do you have any other workaround ideas?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants