Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pnpm i linking to non-existent package when #6118

Closed
rxliuli opened this issue Feb 21, 2023 · 2 comments
Closed

pnpm i linking to non-existent package when #6118

rxliuli opened this issue Feb 21, 2023 · 2 comments

Comments

@rxliuli
Copy link

rxliuli commented Feb 21, 2023

pnpm version: 7.27.1

Code to reproduce the issue:

When executing pnpm i @types/@gera2ld/tarjs, the dependency "tarjs": "link:@types/@gera2ld/tarjs" will be added, there are two problems here

  1. @types/@gera2ld/tarjs does not seem to be a legal npm package name, why it can be parsed and executed successfully
  2. After pnpm i, there is only one empty file under node_modules because @types/@gera2ld/tarjs cannot be found

Expected behavior:

The correct behavior should be that an error should be thrown when installing such a non-existing package?

Actual behavior:

Additional information:

  • node -v prints: v18.14.0
  • Windows, macOS, or Linux?: macOS m2
@await-ovo
Copy link
Member

Could we throw a meaningful error just on pnpm add If the linked local path does not have a manifest:

image

I'm not sure if issues that have been fixed before will reappear, such as #3983 and #5125

cc @zkochan

@zkochan
Copy link
Member

zkochan commented Feb 24, 2023

No, we don't have to throw an error in this case. It works as expected.

@zkochan zkochan closed this as not planned Won't fix, can't repro, duplicate, stale Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants