Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

overriding a dependency more than once #6210

Closed
joelmoss opened this issue Mar 13, 2023 · 1 comment · Fixed by #6266
Closed

overriding a dependency more than once #6210

joelmoss opened this issue Mar 13, 2023 · 1 comment · Fixed by #6266

Comments

@joelmoss
Copy link

pnpm version:

7.29.1

Code to reproduce the issue:

{
  "pnpm": {
    "overrides": {
      "prop-types": "$prop-types",
      "eslint-plugin-react>prop-types": "npm:prop-types"
    }
  }
  "dependencies": {
    "prop-types": "github:joelmoss/prop-types#esm"
  }
}

Expected behavior:

I would expect that all dependencies will use prop-types from github:joelmoss/prop-types, except for eslint-plugin-react, which should use prop-types from npm:prop-types.

Actual behavior:

But instead, all dependencies use prop-types from github:joelmoss/prop-types

It appears that only the "prop-types": "$prop-types" is respected, while the remaining is ignored.

Additional information:

  • node -v prints: v19.7.0
  • Windows, macOS, or Linux?: macOS
@toimc
Copy link

toimc commented Mar 18, 2023

same here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants