Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the shell emulator version #6320

Closed
1 task done
shawnmcknight opened this issue Mar 29, 2023 · 2 comments · Fixed by #6339
Closed
1 task done

Update the shell emulator version #6320

shawnmcknight opened this issue Mar 29, 2023 · 2 comments · Fixed by #6339

Comments

@shawnmcknight
Copy link

Describe the user story

I'd like to be able to use ${FOO:+bar} expressions in pnpm's built-in shell emulator. I believe that pnpm is using @yarnpkg/shell to provide the shell emulator support. That package added support for this expression syntax in yarnpkg/berry#3666.

If I'm following correctly, the shell-emulator support comes from the @pnpm/npm-lifecycle package. The package.json for that currently indicates that the version of @yarnpkg/shell being used is 3.2.0-rc.8. According to the CHANGELOG, this functionality was added in version 3.2.0, but I suspect it ended up in either a later rc version of 3.2.0 (there were 6 additional rc versions) or only in 3.2.0 proper since it does not appear to currently be working in pnpm's shell emulator. The latest stable release of that package is 3.2.5 but there are rc versions up to 4.0.0-rc.41.

Describe the solution you'd like

Update the version of @yarnpkg/shell to at least the latest stable version of 3.2.5 which should allow for ${FOO:+bar} expressions in the shell.

Describe the drawbacks of your solution

None that I can think of.

Describe alternatives you've considered

None that I can think of.

@zkochan
Copy link
Member

zkochan commented Mar 29, 2023

ok, sounds good

@shawnmcknight
Copy link
Author

I have submitted pnpm/npm-lifecycle#40 to bump the version of @yarnpkg/shell that is being used.

I guess since that package is in a separate repository, to get this into pnpm core, there would need to be a new release of pnpm/npm-lifecycle followed by a change to the dependencies of @pnpm/lifecycle to use that version.

zkochan added a commit that referenced this issue Apr 1, 2023
zkochan added a commit that referenced this issue Apr 1, 2023
zkochan added a commit that referenced this issue Apr 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants