Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pnpm cannot add dependency to workspace project on windows: Cannot destructure property 'manifest' of 'manifestsByPath[rootDir]' as it is undefined. #6524

Closed
menasheh opened this issue May 9, 2023 · 4 comments · Fixed by #6525 or #7491
Assignees

Comments

@menasheh
Copy link

menasheh commented May 9, 2023

Trying to add a dependency while in a package's subdirectory of pnpm workspace:

pnpm version:

8.4.0

Code to reproduce the issue:

  1. cd to subproject of a pnpm repo
  2. pnpm i vite-plugin-static-copy (any package)

Expected behavior:

pnpm should install the package in the current workspace project

Actual behavior:

$ pnpm i vite-plugin-static-copy
 ERROR  Cannot destructure property 'manifest' of 'manifestsByPath[rootDir]' as it is undefined.

pnpm: Cannot destructure property 'manifest' of 'manifestsByPath[rootDir]' as it is undefined.
at C:\NVM\nvm\versions\node\v18.12.1\bin\node_modules\pnpm\dist\pnpm.cjs:189340:19
at async Promise.all (index 0)
at async recursive (C:\NVM\nvm\versions\node\v18.12.1\bin\node_modules\pnpm\dist\pnpm.cjs:189337:9)
at async installDeps (C:\NVM\nvm\versions\node\v18.12.1\bin\node_modules\pnpm\dist\pnpm.cjs:189727:11)
at async C:\NVM\nvm\versions\node\v18.12.1\bin\node_modules\pnpm\dist\pnpm.cjs:216935:21
at async main (C:\NVM\nvm\versions\node\v18.12.1\bin\node_modules\pnpm\dist\pnpm.cjs:216902:34)
at async runPnpm (C:\NVM\nvm\versions\node\v18.12.1\bin\node_modules\pnpm\dist\pnpm.cjs:217157:5)
at async C:\NVM\nvm\versions\node\v18.12.1\bin\node_modules\pnpm\dist\pnpm.cjs:217149:7

Additional information:

@zkochan zkochan self-assigned this May 10, 2023
zkochan added a commit that referenced this issue May 10, 2023
zkochan added a commit that referenced this issue May 10, 2023
zkochan added a commit that referenced this issue May 10, 2023
@menasheh
Copy link
Author

@zkochan still not working after 8.5.1 release

@menasheh
Copy link
Author

menasheh commented Jun 7, 2023

What would I have to do to test/debug this locally?

noticed that 7.33.0 does not have the issue

@kasper573
Copy link

Happens to me as well using pnpm 8.7.1

grimly added a commit to grimly/pnpm that referenced this issue Jan 4, 2024
@grimly
Copy link
Contributor

grimly commented Jan 4, 2024

The issue is still present on version 8.14.0.

I managed to identify the issue.

I'll submit a PR soon enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants