Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dedupe-peer-dependents disregards version information #6605

Closed
klingenm opened this issue May 29, 2023 · 0 comments · Fixed by #6606
Closed

dedupe-peer-dependents disregards version information #6605

klingenm opened this issue May 29, 2023 · 0 comments · Fixed by #6606
Labels
type: bug

Comments

@klingenm
Copy link
Contributor

pnpm version: 8.6.0

Code to reproduce the issue:

https://github.com/klingenm/dedupe-peer-dependents-repro

Expected behavior:

The peer:

/@apollo/client/3.7.1(graphql@15.8.0)(react@16.8.0) maps to /@apollo/client/3.7.1(graphql@15.8.0)(react-dom@16.8.0)(react@16.8.0)

and

/@apollo/client/3.7.1(graphql@15.8.0)(react@18.2.0) maps to /@apollo/client/3.7.1(graphql@15.8.0)(react-dom@18.2.0)(react@18.2.0)

Actual behavior:

Both:

  • /@apollo/client/3.7.1(graphql@15.8.0)(react@16.8.0)
  • /@apollo/client/3.7.1(graphql@15.8.0)(react@18.2.0)
    maps to

/@apollo/client/3.7.1(graphql@15.8.0)(react-dom@18.2.0)(react@18.2.0)

Additional information:

This is possibly a duplicate of #6200.

  • node -v prints: v16.15.1 (also tested on 18)
  • Windows, macOS, or Linux?: macOS
@klingenm klingenm mentioned this issue May 29, 2023
Merged
zkochan added a commit that referenced this issue Jun 2, 2023
@klingenm @zkochan
fix(resolvePeers): fix deduplication when version missmatch (#6606)
e83eacd 
When dedupe-peer-dependents is enabled (default), use the path to
determine compatibility.

When multiple dependency groups can be deduplicated, the
latter ones are sorted according to number of peers to allow them to
benefit from deduplication.

close #6605

---------

Co-authored-by: Zoltan Kochan <z@kochan.io>
zkochan added a commit that referenced this issue Jun 2, 2023
@klingenm @zkochan
fix(resolvePeers): fix deduplication when version missmatch (#6606)
b7820a0 
When dedupe-peer-dependents is enabled (default), use the path to
determine compatibility.

When multiple dependency groups can be deduplicated, the
latter ones are sorted according to number of peers to allow them to
benefit from deduplication.

close #6605

---------

Co-authored-by: Zoltan Kochan <z@kochan.io>
@pmb0 pmb0 mentioned this issue Nov 6, 2023
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(resolvePeers): fix deduplication when version missmatch klingenm/pnpm
1 participant
@klingenm