refactor(resolve-dependencies): remove ramda isEmpty usages #6753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zkochan
reviewed
Jul 2, 2023
| @@ -120,7 +119,7 @@ function toLockfileDependency ( | |||
| if (opts.depPath[0] !== '/' && !pkg.id.endsWith(opts.depPath)) { | |||
| result['id'] = pkg.id | |||
| } | |||
| if (!isEmpty(pkg.peerDependencies ?? {})) { | |||
| if (Object.keys(pkg.peerDependencies ?? {}).length !== 0) { | |||
There was a problem hiding this comment.
maybe just > 0?
it is 2 chars less
There was a problem hiding this comment.
updated the PR, do not really have preference on this
zkochan
approved these changes
Jul 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replacing usages of Ramda
isEmptywith alternatives.To my surprise - I have discovered that it is really slow.
(it looks like because of allowing too many possible input types, it does a lot of unnecessary work).
before:
after:
that is around 15%, faster by just not using it