Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the temp file path smaller in the CAFS #6842

Closed
zkochan opened this issue Jul 20, 2023 · 3 comments · Fixed by #6845 or #6863
Closed

Make the temp file path smaller in the CAFS #6842

zkochan opened this issue Jul 20, 2023 · 3 comments · Fixed by #6845 or #6863
Assignees

Comments

@zkochan
Copy link
Member

zkochan commented Jul 20, 2023

actually, this one is related to the store. It is caused by this change: #6817

Previously temp files were shorter, now we append _tmp_{process id} to the target file name. We could probably remove the -index.json part to make it shorter.

so the temp file would be /home/ramnes/.local/share/pnpm/store/v3/files/56/52445747ce43b044c4eb076001ab81b1226688bc0fe065dbe7fa57646b5dead14b2967a7e6411e63ef6886bc733d008f1ed63bb67946a7e0620ec40f59d184_tmp_19567

but the target file would be the same

also, in a next major version we could probably make the store path smaller by removing the "files" subdirectory.

Originally posted by @zkochan in #2605 (comment)

@dbrxnds
Copy link

dbrxnds commented Jul 25, 2023

Hi, just upgraded to 8.6.10 to solve this issue but still running into it. The paths also still include -index.json. Do I need to clear something for this to work?

@zkochan
Copy link
Member Author

zkochan commented Jul 25, 2023

I wasn't changing the file names in the store.
I was only making the temp file names shorter.
Try to use a custom store directory location that is closer to the filesystem root.

you can change the store-dir setting.

@zkochan
Copy link
Member Author

zkochan commented Jul 25, 2023

I have forgotten to change it for -json. It should be done in the package-requester package.

@zkochan zkochan reopened this Jul 25, 2023
zkochan added a commit that referenced this issue Jul 26, 2023
close #6842

Co-authored-by: David Michon <dmichon@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants