Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Harmonize CLI download progress output by fixing the number of displayed digits #6901

Closed
1 task done
fwolfst opened this issue Aug 3, 2023 · 0 comments · Fixed by #6902
Closed
1 task done

Harmonize CLI download progress output by fixing the number of displayed digits #6901

fwolfst opened this issue Aug 3, 2023 · 0 comments · Fixed by #6902

Comments

@fwolfst
Copy link
Contributor

fwolfst commented Aug 3, 2023

Describe the user story

Run pnpm install.

Screen.Recording.2023-08-03.at.14.47.55.mov

When using the CLI, download progress jumps digit precision, causing a visual very noisy terminal. It gets more noisy the more parallel downloads happen

Describe the solution you'd like

I'd like the progress to always display the same number of digits (personal preference: 2).

Describe the drawbacks of your solution

None known to me.

Describe alternatives you've considered

None.

fwolfst added a commit to fwolfst/pnpm that referenced this issue Aug 3, 2023
When running the CLI, downloads will show their progress,
e.g. `1.12 MB/ 3 MB`, showing only significant digits.

As the output is constantly updated, the length of the line in the
output might constantly change (2.99 -> 3 -> 3.3 -> 3.33), leading
to a visually very noisy display.

Fixes pnpm#6901
zkochan added a commit that referenced this issue Aug 4, 2023
When running the CLI, downloads will show their progress,
e.g. `1.12 MB/ 3 MB`, showing only significant digits.

As the output is constantly updated, the length of the line in the
output might constantly change (2.99 -> 3 -> 3.3 -> 3.33), leading
to a visually very noisy display.

close #6901

---------

Co-authored-by: Zoltan Kochan <z@kochan.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant