Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pnpm update --interactive output doesn’t fit in console #7109

Closed
2 of 4 tasks
ai opened this issue Sep 18, 2023 · 2 comments
Closed
2 of 4 tasks

pnpm update --interactive output doesn’t fit in console #7109

ai opened this issue Sep 18, 2023 · 2 comments

Comments

@ai
Copy link
Contributor

ai commented Sep 18, 2023

Verify latest release

  • I verified that the issue exists in the latest pnpm release

pnpm version

8.7.6

Which area(s) of pnpm are affected? (leave empty if unsure)

CLI

Link to the code that reproduces this issue or a replay of the bug

No response

Reproduction steps

pnpm update --interactive

I have bug at least in zsh on Black Box terminal.

Describe the Bug

I very like how many information we have on new CLI UI for pnpm update --interactive, but:

  1. The dependencies selection the output looks bad on standard 80 columns window. Even if we have space to fit everything.
  2. After selecting the dependencies the output looks weird on any window size

Issue 1 and 2 on normal window:
Captura desde 2023-09-18 23-04-34
Captura desde 2023-09-18 23-04-58

Issue 2 on big window:
Captura desde 2023-09-18 23-05-34

Expected Behavior

  1. When we render table we can get current window screen and try to choose table columns to fit everything
  2. The second issue looks like a bug

Maybe it is an issue in new library used to render that selection UI? We have no problem on previous UI. I can open issue there.

Which Node.js version are you using?

20.6.1

Which operating systems have you used?

  • macOS
  • Windows
  • Linux

If your OS is a Linux based, which one it is? (Include the version if relevant)

Fedora 38

@IronGeek
Copy link

IronGeek commented Oct 6, 2023

I'm not sure if this is related,
but when the interactive update list contains a package with an unusually-long-string as version, the package name on the next line become obscured...

image

Notice the package below bun-types is <empty> (it should be rollup)

@ai
Copy link
Contributor Author

ai commented Nov 1, 2023

Fixed in latest version

@ai ai closed this as completed Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants