Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The index files in store changed in 8.7.2 #7115

Closed
4 tasks done
linsui opened this issue Sep 20, 2023 · 3 comments · Fixed by #7708
Closed
4 tasks done

The index files in store changed in 8.7.2 #7115

linsui opened this issue Sep 20, 2023 · 3 comments · Fixed by #7708

Comments

@linsui
Copy link

linsui commented Sep 20, 2023

Verify latest release

  • I verified that the issue exists in the latest pnpm release

pnpm version

8.7.2

Which area(s) of pnpm are affected? (leave empty if unsure)

No response

Link to the code that reproduces this issue or a replay of the bug

No response

Reproduction steps

Generate the store with pnpm install with pnpm 8.7.1 and 8.7.2. Check the store. The index files are different. Some files generated by pnpm 8.7.2 don't have version and name in them but the files generated by 8.7.1 have them.

Describe the Bug

The store files changed. When I package a package managed by pnpm for nixpkgs I need to download all deps into the store and calculate the hash. I remove all timestamp and sort the index files to make it reproducible. But the recent update from 8.7.1 to 8.7.2 changed the files.

Expected Behavior

The store files are generated in a stable format.

Which Node.js version are you using?

20.6.1

Which operating systems have you used?

  • macOS
  • Windows
  • Linux

If your OS is a Linux based, which one it is? (Include the version if relevant)

NixOS

@zkochan
Copy link
Member

zkochan commented Sep 21, 2023

ok, we should fix this.

@linsui
Copy link
Author

linsui commented Feb 24, 2024

@zkochan Thanks! Can we expect that the store files format will be kept stable?

@zkochan
Copy link
Member

zkochan commented Feb 24, 2024

yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants