-
-
Notifications
You must be signed in to change notification settings - Fork 936
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing authorization header with tarball URL + basic auth #7371
Labels
Comments
One small correction, it should be |
Sorry, that's my bad! It was a typo. Thanks for the PR ❤️ |
zkochan
added a commit
that referenced
this issue
Dec 5, 2023
close #7371 --------- Co-authored-by: Zoltan Kochan <z@kochan.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Verify latest release
pnpm version
8.11.0
Which area(s) of pnpm are affected? (leave empty if unsure)
CLI, Package manager compatibility
Reproduction steps
Run a server that echoes req.headers, such as
pnpm add
with a secret in the URL:Describe the Bug
The secret is not delivered to the server via an
authorization
header as it is supposed to be.Expected Behavior
npm and yarn deliver the token correctly, as the header:
authorization: 'Basic c2VjcmV0OnVzZXI='
which decodes to
"secret:user"
as expected. pnpm should do the same.Which Node.js version are you using?
v20.8.1
Which operating systems have you used?
If your OS is a Linux based, which one it is? (Include the version if relevant)
Debian GNU/Linux 12 (bookworm) x86_64 (kernel 6.1.0-13-amd64)
The text was updated successfully, but these errors were encountered: