Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pnpm install always shows packages: +4, what's problem? #7384

Closed
2 of 4 tasks
taoliujun opened this issue Dec 6, 2023 · 5 comments · Fixed by #7396
Closed
2 of 4 tasks

pnpm install always shows packages: +4, what's problem? #7384

taoliujun opened this issue Dec 6, 2023 · 5 comments · Fixed by #7396
Assignees

Comments

@taoliujun
Copy link

taoliujun commented Dec 6, 2023

Verify latest release

  • I verified that the issue exists in the latest pnpm release

pnpm version

8.11.0

Which area(s) of pnpm are affected? (leave empty if unsure)

CLI

Link to the code that reproduces this issue or a replay of the bug

No response

Reproduction steps

Upgrade pnpm to 8.11.0, then run pnpm install.

Describe the Bug

After I upgraded pnpm to the latest version (8.11.0), running pnpm install shows the following, but there are no changes in package.json and pnpm-lock.yaml.

image

I also tested several pnpm versions with different install output results.

8.9.2
image

8.10.0
image

8.10.3
image

Expected Behavior

no Packages: +4

Which Node.js version are you using?

20.10.0

Which operating systems have you used?

  • macOS
  • Windows
  • Linux

If your OS is a Linux based, which one it is? (Include the version if relevant)

No response

@wSedlacek
Copy link

wSedlacek commented Dec 6, 2023

I have noticed this too after upgrading. I am on Node 20.10.0 and pnpm 8.11.0 as well.
macOS too.

Lockfile is up to date, resolution step is skipped
Packages: +45
+++++++++++++++++++++++++++++++++++++++++++++

@apottere
Copy link

apottere commented Dec 7, 2023

It seems like a version of this issue was introduced in pnpm v8.10.0, interestingly for me that version shows the total number of packages installed. In some later minor versions of v8.10.x and v8.11.0 it shows +7 instead.

v8.9.2 seems to work:

$ pnpm i
Lockfile is up to date, resolution step is skipped
Already up to date
Done in 728ms
$ pnpm --version
8.9.2

@wSedlacek
Copy link

I tested 8.9.2, 8.10.0, 8.10.1, 8.10.2, 8.10.3, 8.10.4 and 8.11.0 with corepack real quick.

8.9.2 the issue does not occur.
8.10.0-8.10.2 It shows what seems like all the packages (didn’t check the numbers but is like 99% if not all)
8.10.3-8.11.0 shows only a few packages

8.10.3 is interesting because it only has 1 commit other than the version bump.
b4194fe

Something in this commit changed it from showing nearly all the versions to only a few.

@zkochan
Copy link
Member

zkochan commented Dec 9, 2023

@zkochan zkochan self-assigned this Dec 9, 2023
@zkochan
Copy link
Member

zkochan commented Dec 9, 2023

The good news is that this is just a bug in reporting. The packages are not re-added to the node_modules. You can update pnpm to the latest version without worries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants