bundledDependencies field is not always respected #7411
Labels
Comments
jlivak
added a commit
to jlivak/pnpm
that referenced
this issue
Dec 13, 2023
jlivak
added a commit
to jlivak/pnpm
that referenced
this issue
Dec 13, 2023
fix so that a 'true' value in the bundleDependencies field is correctly interpreted (as meaning all dependencies are bundled)
jlivak
added a commit
to jlivak/pnpm
that referenced
this issue
Dec 13, 2023
…7411) update to code that didn't correctly check both bundleDependencies and bundledDependencies
jlivak
added a commit
to jlivak/pnpm
that referenced
this issue
Dec 13, 2023
fix so that a 'true' value in the bundleDependencies field is correctly interpreted (as meaning all dependencies are bundled) close pnpm#7411
jlivak
added a commit
to jlivak/pnpm
that referenced
this issue
Dec 14, 2023
add local tarball test and bundledDependencies=true test update existing tests to confirm that bundled dependencies aren't installed
zkochan
added a commit
to jlivak/pnpm
that referenced
this issue
Dec 19, 2023
zkochan
added a commit
that referenced
this issue
Dec 19, 2023
* fix: check for both bundleDependencies and bundledDependencies (#7411) update to code that didn't correctly check both bundleDependencies and bundledDependencies * fix: support boolean value for bundleDependencies (#7411) fix so that a 'true' value in the bundleDependencies field is correctly interpreted (as meaning all dependencies are bundled) close #7411 * fix: allow saving of boolean bundledDependencies values updates prior fix to allow saving booleans to bundledDependencies field. * fix: add test coverage for bundledDependencies fixes (#7411) add local tarball test and bundledDependencies=true test update existing tests to confirm that bundled dependencies aren't installed * fix: update registry-mock * docs: update changeset * fix: update bundleDependencies tests * Revert "fix: update registry-mock" This reverts commit 0c4b7ed. * Revert "Revert "fix: update registry-mock"" This reverts commit 9828dfc. * test: update integrities in test lockfiles * test: retry twice * test: move bundle deps test to separate file --------- Co-authored-by: Zoltan Kochan <z@kochan.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Verify latest release
pnpm version
No response
Which area(s) of pnpm are affected? (leave empty if unsure)
Dependencies resolver
Link to the code that reproduces this issue or a replay of the bug
No response
Reproduction steps
Attempt to
pnpm adda tarball dependency which has either:bundledDependenciesdeclared in package.json instead ofbundleDependenciesbundleDependenciesfield set to trueDescribe the Bug
Even though the dependencies should be bundled, pnpm will attempt to pull them from the default package registry. This causes the install to fail if any of the bundled dependencies are private packages.
Expected Behavior
The bundled dependencies should be used and they should not be fetched from the package registry.
Which Node.js version are you using?
20.3.0
Which operating systems have you used?
If your OS is a Linux based, which one it is? (Include the version if relevant)
No response
The text was updated successfully, but these errors were encountered: