--update-interactive output does not support light theme in terminal

[ai]

Verify latest release

• I verified that the issue exists in the latest pnpm release

pnpm version

8.12.1

Which area(s) of pnpm are affected? (leave empty if unsure)

CLI

Link to the code that reproduces this issue or a replay of the bug

No response

Reproduction steps

1. Enable light theme in terminal
2. Run pnpm update-interactive

Describe the Bug

Selection checkboxes are invisible

Expected Behavior

Use gray color for checkbox instead of #fff. Named colors are safe for different color themes.

Which Node.js version are you using?

20.10.0

Which operating systems have you used?

• macOS
• Windows
• Linux

If your OS is a Linux based, which one it is? (Include the version if relevant)

Fedora 38

[KSXGitHub]

You can try tweak it in pkg-manager/plugin-commands-installation/src/update/index.ts and create a PR.

[ai]

@KSXGitHub thanks for pointing the file.

PR is here #7454

[zkochan]

In what terminal is the issue reproducible? In alacritty (on macOS), I see the selection boxes (I use a light theme).

[ai]

Black Box, Linux. The visibility depends on theme, but not great in most of them.

Here is a standard GNOME Terminal with default theme (visible, but hard to read)

I agree that white doesn’t work completely only on some themes. But in general, I think it is not a “safe” color.