Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bundledDependencies: false inconsistently added to pnpm-lock.yaml #7576

Closed
3 of 4 tasks
jfirebaugh opened this issue Jan 26, 2024 · 3 comments · Fixed by #7580
Closed
3 of 4 tasks

bundledDependencies: false inconsistently added to pnpm-lock.yaml #7576

jfirebaugh opened this issue Jan 26, 2024 · 3 comments · Fixed by #7580
Assignees

Comments

@jfirebaugh
Copy link

Verify latest release

  • I verified that the issue exists in the latest pnpm release

pnpm version

No response

Which area(s) of pnpm are affected? (leave empty if unsure)

Lockfile

Link to the code that reproduces this issue or a replay of the bug

No response

Reproduction steps

Run pnpm install --lockfile-only --ignore-scripts locally and commit the lockfile. Run pnpm install --lockfile-only --ignore-scripts in CI, with the identical version of pnpm, and then git diff --exit-code -- pnpm-lock.yaml. The expected result is that there are no changes to the lockfile.

Describe the Bug

Sometimes, there are changes to the lockfile, namely that locally pnpm install --lockfile-only --ignore-scripts has added bundledDependencies: false to certain dependencies, whereas in CI it is not present.

diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
index 1d7740ed185..a5f9996888b 100644
--- a/pnpm-lock.yaml
+++ b/pnpm-lock.yaml
@@ -25507,7 +25507,6 @@ packages:
       loose-envify: 1.4.0
       object-assign: 4.1.1
     dev: false
-    bundledDependencies: false
   /create-react-context@0.3.0(prop-types@15.8.1)(react@18.2.0):
     resolution: {integrity: sha512-dNldIoSuNSvlTJ7slIKC/ZFGKexBMBrrcc+TTe1NdmROnaASuLPvqpwj9v4XS4uXZ8+YPu0sNmShX2rXI5LNsw==}
@@ -40647,7 +40646,6 @@ packages:
     transitivePeerDependencies:
       - supports-color
     dev: false
-    bundledDependencies: false
   /react-diff-viewer-continued@3.2.4(react-dom@18.2.0)(react@18.2.0):
     resolution: {integrity: sha512-4LyUBVTnv82I87SiqoyfFugQ4+7s/52IdJZVPsAYMfxEm7irBteGYNFrBqzznTsPeLHD61lRxlPY/s+aSts15Q==}

Expected Behavior

Consistent behavior with regards to bundledDependencies: false no matter where pnpm is run.

Which Node.js version are you using?

18.17.1

Which operating systems have you used?

  • macOS
  • Windows
  • Linux

If your OS is a Linux based, which one it is? (Include the version if relevant)

Debian Bullseye

@jfirebaugh
Copy link
Author

Bisects to 8.13.1 -- 8.13.0 does not add bundledDependencies: false locally.

@zkochan zkochan added this to Status Jan 26, 2024
@zkochan zkochan moved this to Priority in Status Jan 26, 2024
@zkochan
Copy link
Member

zkochan commented Jan 27, 2024

Could you share what packages in the lockfile have the bundledDependencies: false field?

@zkochan
Copy link
Member

zkochan commented Jan 27, 2024

This change is probably related: #7412

It was released in 8.13.1

I have tried to publish a package with "bundleDependencies": true but it looks like npm normalizes it to an array, so I don't know how to test this.

@zkochan zkochan self-assigned this Jan 27, 2024
zkochan added a commit that referenced this issue Jan 27, 2024
close #7576
zkochan added a commit that referenced this issue Jan 28, 2024
@zkochan zkochan moved this from Priority to in progress in Status Feb 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants