Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: recursive update with workspace alias #7999

Merged
merged 15 commits into from Apr 29, 2024

Conversation

KSXGitHub
Copy link
Contributor

@KSXGitHub KSXGitHub commented Apr 23, 2024

Fixes #7975


TODO:

  • Rename the module.
  • Change ParsedWorkspacePref into a class that allows modification and stringification.
    • Refactor to use the class.
  • Write tests for @pnpm/workspace.spec-parser.

@KSXGitHub KSXGitHub marked this pull request as ready for review April 25, 2024 10:49
workspace/spec-parser/test/workspace-spec.test.ts Outdated Show resolved Hide resolved
workspace/spec-parser/package.json Outdated Show resolved Hide resolved
@KSXGitHub KSXGitHub requested a review from zkochan April 29, 2024 15:17
@zkochan zkochan merged commit cb0f459 into main Apr 29, 2024
11 of 13 checks passed
@zkochan zkochan deleted the upgrading-does-not-work-with-aliased-workspace-dep-7975 branch April 29, 2024 23:17
@zkochan
Copy link
Member

zkochan commented Apr 29, 2024

The test could be written in @pnpm/core, I guess. But fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrading packages doesn't work when an aliased workspace dependency is present
2 participants