Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Peer deps issue errors are not reported #7978

Open
1 of 4 tasks
moltar opened this issue Apr 19, 2024 · 4 comments
Open
1 of 4 tasks

Peer deps issue errors are not reported #7978

moltar opened this issue Apr 19, 2024 · 4 comments

Comments

@moltar
Copy link

moltar commented Apr 19, 2024

Verify latest release

  • I verified that the issue exists in the latest pnpm release

pnpm version

9.0.4

Which area(s) of pnpm are affected? (leave empty if unsure)

CLI

Link to the code that reproduces this issue or a replay of the bug

N/A

Reproduction steps

Not truly sure how to repro.

Describe the Bug

Running pnpm i --no-frozen-lockfile silently fails, with an exit code 1 when there are peer issues.

When I run pnpm i --no-frozen-lockfile --reporter ndjson, I see the error ERR_PNPM_PEER_DEP_ISSUES.

I won't paste the entire log entry, as it's massive.

vite","version":"5.0.7"}],"optional":true,"wantedRange":"^5.4.0"},{"parents":[{"name":"vite","version":"5.2.9"}],"optional":true,"wantedRange":"^5.4.0"}],"@edge-runtime/vm":[{"parents":[{"name":"vitest","version":"1.5.0"}],"optional":true,"wantedRange":"*"}],"happy-dom":[{"parents":[{"name":"vitest","version":"1.5.0"}],"optional":true,"wantedRange":"*"}],"jsdom":[{"parents":[{"name":"vitest","version":"1.5.0"}],"optional":true,"wantedRange":"*"}],"@vitest/ui":[{"parents":[{"name":"vitest","version":"1.5.0"}],"optional":true,"wantedRange":"1.5.0"}],"@vitest/browser":[{"parents":[{"name":"vitest","version":"1.5.0"}],"optional":true,"wantedRange":"1.5.0"}]},"conflicts":[],"intersections":{}},"packages/aws-region":{"bad":{},"missing":{"aws-crt":[{"parents":[{"name":"@aws-sdk/client-ssm","version":"3.554.0"},{"name":"@aws-sdk/client-sts","version":"3.554.0"},{"name":"@aws-sdk/util-user-agent-node","version":"3.535.0"}],"optional":true,"wantedRange":">=1.0.0"}],"supports-color":[{"parents":[{"name":"@stylistic/eslint-plugin","version":"1.7.0"},{"name":"@stylistic/eslint-plugin-plus","version":"1.7.0"},{"name":"@typescript-eslint/utils","version":"6.21.0"},{"name":"@typescript-eslint/typescript-estree","version":"6.21.0"},{"name":"debug","version":"4.3.4"}],"optional":true,"wantedRange":"*"},{"parents":[{"name":"eslint-import-resolver-node","version":"0.3.9"},{"name":"debug","version":"3.2.7"}],"optional":true,"wantedRange":"*"}],"eslint-import-resolver-webpack":[{"parents":[{"name":"eslint-import-resolver-typescript","version":"3.6.1"},{"name":"eslint-module-utils","version":"2.8.0"}],"optional":true,"wantedRange":"*"}],"ts-node":[{"parents":[{"name":"tsup","version":"8.0.2"},{"name":"postcss-load-config","version":"4.0.2"}],"optional":true,"wantedRange":">=9.0.0"}],"@swc/core":[{"parents":[{"name":"tsup","version":"8.0.2"}],"optional":true,"wantedRange":"^1"}],"@microsoft/api-extractor":[{"parents":[{"name":"tsup","version":"8.0.2"}],"optional":true,"wantedRange":"^7.36.0"}]},"conflicts":[],"intersections":{}}},"name":"pnpm","err":{"name":"pnpm","message":"Unmet peer dependencies","code":"ERR_PNPM_PEER_DEP_ISSUES","stack":"pnpm: Unmet peer dependencies\n    at reportPeerDependencyIssues (/Users/foo/.cache/node/corepack/pnpm/9.0.4/dist/pnpm.cjs:180686:15)\n    at _installInContext (/Users/foo/.cache/node/corepack/pnpm/9.0.4/dist/pnpm.cjs:181602:67)\n    at async installInContext (/Users/foo/.cache/node/corepack/pnpm/9.0.4/dist/pnpm.cjs:181652:16)\n    at async _install (/Users/foo/.cache/node/corepack/pnpm/9.0.4/dist/pnpm.cjs:181165:25)\n    at async mutateModules (/Users/foo/.cache/node/corepack/pnpm/9.0.4/dist/pnpm.cjs:180843:23)\n    at async recursive (/Users/foo/.cache/node/corepack/pnpm/9.0.4/dist/pnpm.cjs:182382:50)\n    at async installDeps (/Users/foo/.cache/node/corepack/pnpm/9.0.4/dist/pnpm.cjs:182685:11)\n    at async /Users/foo/.cache/node/corepack/pnpm/9.0.4/dist/pnpm.cjs:211540:21\n    at async main (/Users/foo/.cache/node/corepack/pnpm/9.0.4/dist/pnpm.cjs:211503:34)\n    at async runPnpm (/Users/foo/.cache/node/corepack/pnpm/9.0.4/dist/pnpm.cjs:211754:5)"}}

Expected Behavior

Print some error.

Which Node.js version are you using?

v18.19.0

Which operating systems have you used?

  • macOS
  • Windows
  • Linux

If your OS is a Linux based, which one it is? (Include the version if relevant)

No response

@moltar
Copy link
Author

moltar commented Apr 19, 2024

Here's an easier to read last log line. I folded issuesByProjects as it's a huge blob of JSON.

screenshot-20240419T211027-MqZbNE5d@2x

@moltar
Copy link
Author

moltar commented Apr 19, 2024

It's full of entries like this:

screenshot-20240419T211252-FDCmU1QZ@2x

Btw, I have strict-peer-dependencies=true on in .npmrc

@moltar
Copy link
Author

moltar commented Apr 27, 2024

Closing, as I think the cause is this #7952

@moltar moltar closed this as completed Apr 27, 2024
@moltar moltar reopened this Apr 27, 2024
@moltar
Copy link
Author

moltar commented Apr 27, 2024

Wait, no, the issue is related, but not the cause. The lack of reporting of issues is still a problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant