Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pnpm i -S a-module-already-in-dev-deps should show message that it wasn't moved to dependencies #926

Closed
vjpr opened this issue Oct 29, 2017 · 4 comments · Fixed by #7319 or #7348
Closed

pnpm i -S a-module-already-in-dev-deps should show message that it wasn't moved to dependencies #926

vjpr opened this issue Oct 29, 2017 · 4 comments · Fixed by #7319 or #7348
Labels
area: reporting good first issue size: S

Comments

@vjpr
Copy link
Contributor

vjpr commented Oct 29, 2017 •
edited

I think this is good behaviour, but there should be message warning the user that it was already in devDeps and was not moved, and they should do it manually.

pnpm version: 1.18.1

pnpm i -D lodash@1
pnpm i -S lodash@latest

Still in dev deps.

Should warn user it was not moved.

Additional information:

  • node -v prints: 8.8.1
  • Windows, OS X, or Linux?: macOS
@vjpr vjpr changed the title pnpm i -S a-module-already-in-dev-deps doesn't move to dependencies pnpm i -S a-module-already-in-dev-deps should show message that it wasn't moved to dependencies Oct 29, 2017
@zkochan
Copy link
Member

zkochan commented Nov 1, 2017

This doesn't work because to move lodash to prod dependencies, you have to use the -P/--save-prod flag.

I am not against a warning though.

Also, I noticed that summary is not printed when dependency is moved from one type to other. It should print something like this:

devDependencies:
- lodash 1.0.0

dependencies
+ lodash 1.0.0

zkochan added a commit to pnpm/logger that referenced this issue Nov 3, 2017
@zkochan
feat: add manifest logger
aafe6c4 
ref pnpm/pnpm#926
zkochan added a commit to pnpm/supi that referenced this issue Nov 3, 2017
@zkochan
feat: log dependency type changes
f358ffd 
ref pnpm/pnpm#926
zkochan added a commit to pnpm/supi that referenced this issue Nov 3, 2017
@zkochan
feat: log dependency type changes
1e44529 
ref pnpm/pnpm#926
zkochan added a commit that referenced this issue Nov 3, 2017
@zkochan
fix: log dependency type changes
de8e70b 
ref #926
zkochan added a commit that referenced this issue Nov 3, 2017
@zkochan
fix: log dependency type changes
add5134 
ref #926
zkochan added a commit that referenced this issue Nov 3, 2017
@zkochan
fix: log dependency type changes
053c8be 
ref #926
zkochan added a commit that referenced this issue Nov 4, 2017
@zkochan
fix: log dependency type changes
07ef46c 
ref #926
zkochan added a commit that referenced this issue Nov 4, 2017
@zkochan
fix: log dependency type changes
5c4f0a5 
ref #926
@yaodingyd
Copy link
Member

I think this issue is already resolved.

@DanielRuf
Copy link
Contributor

I think this issue is already resolved.

There is still no message:

grafik

@Yanzi-dev
Copy link
Contributor

Yanzi-dev commented Nov 14, 2023 •
edited

Hello, I started working on it.

This is what i get
image

Working on fixing tests right now.

@Yanzi-dev Yanzi-dev mentioned this issue Nov 15, 2023
Merged
zkochan pushed a commit that referenced this issue Nov 20, 2023
@Yanzi-dev
fix: pnpm add a-module-already-in-dev-deps should show message that…
45bdc79 
… it wasn't moved to dependencies (#7319)

close #926
@Yanzi-dev Yanzi-dev mentioned this issue Nov 27, 2023
Merged
zkochan added a commit that referenced this issue Dec 27, 2023
@Yanzi-dev @zkochan
feat: pnpm i a-module-already-in-dev-deps should show message (#7348)
fac2ed4 
close #926

---------

Co-authored-by: Zoltan Kochan <z@kochan.io>
gluxon pushed a commit to gluxon/pnpm that referenced this issue Dec 27, 2023
@Yanzi-dev @zkochan @gluxon
feat: pnpm i a-module-already-in-dev-deps should show message (pnpm#7348
5122466 
)

close pnpm#926

---------

Co-authored-by: Zoltan Kochan <z@kochan.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: reporting good first issue size: S
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feat/pnpm i module already in dev deps
feat: pnpm i a-module-already-in-dev-deps should show message
5 participants
@vjpr @DanielRuf @zkochan @yaodingyd @Yanzi-dev