fix(lockfile): change sorting of keys in lockfile #5151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make it more deterministic and prevent unnecessary churn in the lockfile. It is useful when looking for affected projects after changes to the lockfile. When the changes happen among various developers using various locale, the locale specific sorting causes changes in the lockfile for extraneous projects. Therefore, it could cause running unnecessary CI jobs, builds, releases and other work that would not be needed otherwise.
|
💖 Thanks for opening this pull request! 💖 |
zkochan
approved these changes
Aug 4, 2022
|
Congrats on merging your first pull request! 🎉🎉🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make it more deterministic and prevent unnecessary churn in the lockfile. It is useful when looking for affected projects after changes to the lockfile. When the changes happen among various developers using various locale, the locale specific sorting causes changes in the lockfile for extraneous projects. Therefore, it could cause running unnecessary CI jobs, builds, releases and other work that would not be needed otherwise.
The
localeComparewas used first time in this commit for this specific use case.