feat(plugin-command-patching): add path option to patch command #5304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💖 Thanks for opening this pull request! 💖 |
roseline124
changed the title
zkochan
requested changes
Sep 3, 2022
zkochan
force-pushed
the
feat/new-patch-args
branch
from
4942b8f
to
92ab5ca
Compare
zkochan
approved these changes
Sep 4, 2022
|
Congrats on merging your first pull request! 🎉🎉🎉 |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this pr is about #5293.
Background
There are cases where I want to access the existing patched project folder if I patch the package again. However, the temporary link given by 'pnpm-cli' is complicated and difficult to access again.
as is
pnpm patch <packageName>to be
pnpm patch <packageName> [--path | -p <directoryPath>]It makes developer to access patch package directory again.
how about this..?
It would be better the patch directory prefix is set with
pnpm-patches/<project-name>when given path option?