Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pushing to this repo #15

Open
coyotte508 opened this issue Dec 17, 2012 · 1 comment
Open

Pushing to this repo #15

coyotte508 opened this issue Dec 17, 2012 · 1 comment
Labels

Comments

@coyotte508
Copy link
Member

@CrystalMoogle @shadowfist @lamperi 馃悪

This is just to decide what to do with this repo. Imo every big change should be made into a pull request, and someone else can review/accept/question the code.

So everyone is familiar with the code and it's reviewed before being put in. Ofc minor fixes and urgent fixes bypass that.

Opinions?

(by the way i got a pull request pending :p, i'd appreciate a little merge)

@lamperi
Copy link

lamperi commented Dec 17, 2012

I'm all on for people reviewing each other's code before adding into any official repo. However, is the code still in such a early state that it needs lots of new features - then it might not be wise if you manage to get someone who's eager to code for the rpg scripts and knows how to do their stuff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants