Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTPClientSession and DEFAULT_KEEP_ALIVE_TIMEOUT #4457

Open
micheleselea opened this issue Feb 14, 2024 · 0 comments
Open

HTTPClientSession and DEFAULT_KEEP_ALIVE_TIMEOUT #4457

micheleselea opened this issue Feb 14, 2024 · 0 comments

Comments

@micheleselea
Copy link
Contributor

In HTTPClientSession, when in keepalive, we use the default 8 seconds DEFAULT_KEEP_ALIVE_TIMEOUT to check with _lastRequest and control if the connection has to reconnect. The _lastRequest is updated on sendRequestImpl()
I was thinking that probably we should update _lastRequest even after response received, otherwise if a response last 8 seconds you will always end up with a reconnection make the keep alive setting useless: it's just something I asking myself, what do you think about?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant