Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Log #702

Open
kennylavender opened this issue Nov 1, 2018 · 1 comment
Open

Refactor Log #702

kennylavender opened this issue Nov 1, 2018 · 1 comment
Assignees
Labels

Comments

@kennylavender
Copy link
Contributor

We are now using a curried log method with pipeP/asyncPipe pretty successfully, I think its time we extract it into a helper or something so that files can import a function that returns log and the types instead of repeating the pattern everywhere.

@lautarodragan
Copy link
Member

lautarodragan commented Nov 1, 2018

Agreed. This is not needed for mainnet, but we're introducing a bunch of duplicated code which this refactor would avoid. Should be pretty small, too.

@geoffturk geoffturk added this to the Mainnet-launch milestone Nov 1, 2018
@geoffturk geoffturk modified the milestones: Mainnet-launch, PML1 Nov 12, 2018
@geoffturk geoffturk removed this from the PML1 milestone Nov 29, 2018
@geoffturk geoffturk added ct-z and removed ct-z labels Nov 29, 2018
@geoffturk geoffturk added this to the PML1 milestone Nov 29, 2018
@lautarodragan lautarodragan removed this from the PML1 milestone Jan 4, 2019
@lautarodragan lautarodragan self-assigned this Jan 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants