Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Banner on CUSTOM position? #123

Open
GogetaX opened this issue Sep 7, 2022 · 6 comments
Open

[FEATURE] Banner on CUSTOM position? #123

GogetaX opened this issue Sep 7, 2022 · 6 comments
Assignees
Labels
android Android platform enhancement New feature or request help wanted Extra attention is needed ios iOS platform
Milestone

Comments

@GogetaX
Copy link

GogetaX commented Sep 7, 2022

Is your feature request related to a problem? Please describe.
the title says it all.
should be like X,Y coordinates from TOP or from BOTTOM
or i can set the position of the banner in the code before creating it?
or set the position on the banner with Percentage?

@GogetaX GogetaX added the enhancement New feature or request label Sep 7, 2022
@gumaciel gumaciel self-assigned this Oct 4, 2022
@gumaciel
Copy link
Contributor

gumaciel commented Oct 4, 2022

Thank you i will investigate this

@gumaciel gumaciel removed their assignment Oct 4, 2022
@gumaciel
Copy link
Contributor

gumaciel commented Oct 4, 2022

I'll keep this Issue open, I was researching and I don't know if it's entirely possible what you want.

I believe that with NativeAds it is possible, but I don't know if with Banner it is.

If anyone is interested in working on this feature I would appreciate it.

@gumaciel gumaciel added help wanted Extra attention is needed question Further information is requested labels Oct 4, 2022
@gumaciel
Copy link
Contributor

on poingstudios/godot-admob-ios#45 it should be possible to change the position like:

class_name AdPosition

enum Values {
	TOP,
	BOTTOM,
	LEFT,
	RIGHT,
	TOP_LEFT,
	TOP_RIGHT,
	BOTTOM_LEFT,
	BOTTOM_RIGHT,
	CENTER
}

but not custom, it should be done on v3.1.0

@gumaciel gumaciel changed the title [FEATURE] Banner on TOP/BOTTOM/CUSTOM? [FEATURE] Banner on CUSTOM position? Jun 20, 2023
@gumaciel gumaciel transferred this issue from poingstudios/godot-admob-ios Dec 23, 2023
@gumaciel gumaciel added this to the v3.2.0 milestone Dec 23, 2023
@gumaciel gumaciel added ios iOS platform android Android platform labels Dec 23, 2023
@gumaciel gumaciel self-assigned this Dec 23, 2023
@StrawberrySandwich
Copy link

Hey just to add some more input here, maybe what GogetaX was experiencing and maybe different.

I want my banner ads to be positioned across the top of the game's viewport permanently.
It appears that the AdPosition.TOP setting always positions the ad at the top of the device's screen.
If there isn't sufficient space between the top of the viewport and the top of the screen then the banner will overlap the game view.
If there is too much space due to maintaining aspect ratio, the ad will be at the top and there will be black space between the game view and the ad.

It feels awkward that I (don't think at least) can't position the ad just above the game view.

@StrawberrySandwich
Copy link

Actually, I believe that the overlapping is technically a violation from admob policy. Check the Ad overlapping with app content section in the link below.

https://support.google.com/admob/answer/6275345?hl=en#:~:text=Ad%20overlapping%20with%20app%20content,seen%20in%20the%20example%20below.

@gumaciel
Copy link
Contributor

Hi @StrawberrySandwich this is different, this seems like you're reporting a bug, but I'm not sure if it's a bug.

Can you show a print screen of the current behavior and how you think it should be?


If you're talking about Superview and want your ads to display within it, this is not possible on our new version and it's neither recommended by Google: https://developers.google.com/admob/ios/x-ad-rendering

Banner ads must be placed in the "Safe Area" to avoid being obscured by rounded corners, sensor housing, and the Home indicator. On this page you'll find examples of how to add constraints to position a banner to the top or bottom of the Safe Area.

So I recommend that you attempt to showcase your user interface (UI) within the Safe Area of the device to mitigate this issue.

@gumaciel gumaciel removed the question Further information is requested label May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
android Android platform enhancement New feature or request help wanted Extra attention is needed ios iOS platform
Projects
Status: Todo
Development

No branches or pull requests

3 participants