Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConsentInformation.update callbacks are called repeatedly #134

Closed
abcjjy opened this issue Mar 5, 2024 · 2 comments · Fixed by #141
Closed

ConsentInformation.update callbacks are called repeatedly #134

abcjjy opened this issue Mar 5, 2024 · 2 comments · Fixed by #141
Labels
bug Something isn't working
Milestone

Comments

@abcjjy
Copy link

abcjjy commented Mar 5, 2024

Godot version

4.2

Plugin version

3.1.0

System information

Godot v4.2.stable - macOS 13.6.1 - GLES3 (Compatibility) - ANGLE (AMD, ANGLE Metal Renderer: AMD Radeon Pro 560X, 版本13.6.1(版号22G313)) - Intel(R) Core(TM) i7-8850H CPU @ 2.60GHz (12 Threads)

Phone information, if applicable

iPhone X iOS 14.8

Issue description

Each time ConsentInformation.update is called, new callbacks are connected to the inner signals. In later call to update(), previous callbacks are also fired.

An option is passing Callables into native plugin instead of using signals.

UserMessagingPlatform.load_consent_form has similar issues too.

Steps to reproduce

Call ConsentInformation.update multiple times, all the used callbacks are called.

Additional context

No response

@abcjjy abcjjy added the bug Something isn't working label Mar 5, 2024
@gumaciel
Copy link
Contributor

gumaciel commented Mar 6, 2024

thank you for opening this issue, i will verify this

@gumaciel gumaciel added this to the v3.1.1 milestone May 30, 2024
@gumaciel gumaciel linked a pull request May 31, 2024 that will close this issue
@gumaciel
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants