Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panic on equality operation between Series of type List(Struct(Enum)) #16209

Open
2 tasks done
stinodego opened this issue May 14, 2024 · 0 comments
Open
2 tasks done
Labels
A-dtype-categorical Area: categorical data type bug Something isn't working P-medium Priority: medium python Related to Python Polars

Comments

@stinodego
Copy link
Member

Checks

  • I have checked that this issue has not already been reported.
  • I have confirmed this bug exists on the latest version of Polars.

Reproducible example

import polars as pl

dtype = pl.List(pl.Struct({"a": pl.Enum(["c0"])}))
s = pl.Series(dtype=dtype)

result = s.eq(s)
print(result)

Log output

thread '<unnamed>' panicked at crates/polars-core/src/series/from.rs:332:25:
called `Option::unwrap()` on a `None` value
stack backtrace:
   0: rust_begin_unwind
             at /rustc/0d8b3346a3992ab11ea35ff0fb95a6864b91f797/library/std/src/panicking.rs:645:5
   1: core::panicking::panic_fmt
             at /rustc/0d8b3346a3992ab11ea35ff0fb95a6864b91f797/library/core/src/panicking.rs:72:14
   2: core::panicking::panic
             at /rustc/0d8b3346a3992ab11ea35ff0fb95a6864b91f797/library/core/src/panicking.rs:141:5
   3: core::option::unwrap_failed
             at /rustc/0d8b3346a3992ab11ea35ff0fb95a6864b91f797/library/core/src/option.rs:1984:5
   4: core::option::Option<T>::unwrap
             at /rustc/0d8b3346a3992ab11ea35ff0fb95a6864b91f797/library/core/src/option.rs:932:21
   5: polars_core::series::from::<impl polars_core::series::Series>::_try_from_arrow_unchecked_with_md
             at /home/stijn/code/polars/crates/polars-core/src/series/from.rs:332:25
   6: polars_core::series::from::<impl polars_core::series::Series>::_try_from_arrow_unchecked_with_md::{{closure}}
             at /home/stijn/code/polars/crates/polars-core/src/series/from.rs:435:25
   7: core::iter::adapters::map::map_try_fold::{{closure}}
             at /rustc/0d8b3346a3992ab11ea35ff0fb95a6864b91f797/library/core/src/iter/adapters/map.rs:96:28
   8: core::iter::traits::iterator::Iterator::try_fold
             at /rustc/0d8b3346a3992ab11ea35ff0fb95a6864b91f797/library/core/src/iter/traits/iterator.rs:2409:21
   9: <core::iter::adapters::map::Map<I,F> as core::iter::traits::iterator::Iterator>::try_fold
             at /rustc/0d8b3346a3992ab11ea35ff0fb95a6864b91f797/library/core/src/iter/adapters/map.rs:122:9
  10: <core::iter::adapters::GenericShunt<I,R> as core::iter::traits::iterator::Iterator>::try_fold
             at /rustc/0d8b3346a3992ab11ea35ff0fb95a6864b91f797/library/core/src/iter/adapters/mod.rs:201:9
  11: core::iter::traits::iterator::Iterator::try_for_each
             at /rustc/0d8b3346a3992ab11ea35ff0fb95a6864b91f797/library/core/src/iter/traits/iterator.rs:2471:9
  12: <core::iter::adapters::GenericShunt<I,R> as core::iter::traits::iterator::Iterator>::next
             at /rustc/0d8b3346a3992ab11ea35ff0fb95a6864b91f797/library/core/src/iter/adapters/mod.rs:184:14
  13: <alloc::vec::Vec<T> as alloc::vec::spec_from_iter_nested::SpecFromIterNested<T,I>>::from_iter
             at /rustc/0d8b3346a3992ab11ea35ff0fb95a6864b91f797/library/alloc/src/vec/spec_from_iter_nested.rs:26:32
  14: <alloc::vec::Vec<T> as alloc::vec::spec_from_iter::SpecFromIter<T,I>>::from_iter
             at /rustc/0d8b3346a3992ab11ea35ff0fb95a6864b91f797/library/alloc/src/vec/spec_from_iter.rs:33:9
  15: <alloc::vec::Vec<T> as core::iter::traits::collect::FromIterator<T>>::from_iter
             at /rustc/0d8b3346a3992ab11ea35ff0fb95a6864b91f797/library/alloc/src/vec/mod.rs:2948:9
  16: core::iter::traits::iterator::Iterator::collect
             at /rustc/0d8b3346a3992ab11ea35ff0fb95a6864b91f797/library/core/src/iter/traits/iterator.rs:2003:9
  17: <core::result::Result<V,E> as core::iter::traits::collect::FromIterator<core::result::Result<A,E>>>::from_iter::{{closure}}
             at /rustc/0d8b3346a3992ab11ea35ff0fb95a6864b91f797/library/core/src/result.rs:1935:51
  18: core::iter::adapters::try_process
             at /rustc/0d8b3346a3992ab11ea35ff0fb95a6864b91f797/library/core/src/iter/adapters/mod.rs:170:17
  19: <core::result::Result<V,E> as core::iter::traits::collect::FromIterator<core::result::Result<A,E>>>::from_iter
             at /rustc/0d8b3346a3992ab11ea35ff0fb95a6864b91f797/library/core/src/result.rs:1935:9
  20: core::iter::traits::iterator::Iterator::collect
             at /rustc/0d8b3346a3992ab11ea35ff0fb95a6864b91f797/library/core/src/iter/traits/iterator.rs:2003:9
  21: polars_core::series::from::<impl polars_core::series::Series>::_try_from_arrow_unchecked_with_md
             at /home/stijn/code/polars/crates/polars-core/src/series/from.rs:430:30
  22: polars_core::series::from::<impl polars_core::series::Series>::_try_from_arrow_unchecked
             at /home/stijn/code/polars/crates/polars-core/src/series/from.rs:141:9
  23: polars_core::series::from::<impl polars_core::series::Series>::from_chunks_and_dtype_unchecked
             at /home/stijn/code/polars/crates/polars-core/src/series/from.rs:105:17
  24: polars_core::chunked_array::cast::cast_list
             at /home/stijn/code/polars/crates/polars-core/src/chunked_array/cast.rs:507:9
  25: polars_core::chunked_array::cast::<impl polars_core::chunked_array::ops::ChunkCast for polars_core::chunked_array::ChunkedArray<polars_core::datatypes::ListType>>::cast
             at /home/stijn/code/polars/crates/polars-core/src/chunked_array/cast.rs:388:49
  26: polars_core::series::implementations::list::<impl polars_core::series::series_trait::SeriesTrait for polars_core::series::implementations::SeriesWrap<polars_core::chunked_array::ChunkedArray<polars_core::datatypes::ListType>>>::cast
             at /home/stijn/code/polars/crates/polars-core/src/series/implementations/list.rs:121:9
  27: polars_core::series::Series::cast
             at /home/stijn/code/polars/crates/polars-core/src/series/mod.rs:348:19
  28: polars_core::series::Series::to_physical_repr
             at /home/stijn/code/polars/crates/polars-core/src/series/mod.rs:496:39
  29: polars_core::series::comparison::<impl polars_core::chunked_array::ops::ChunkCompare<&polars_core::series::Series> for polars_core::series::Series>::equal
             at /home/stijn/code/polars/crates/polars-core/src/series/comparison.rs:109:9
  30: polars::series::comparison::<impl polars::series::PySeries>::eq
             at ./src/series/comparison.rs:10:17
  31: polars::series::comparison::<impl polars::series::PySeries>::__pymethod_eq__
             at ./src/series/comparison.rs:7:1
  32: pyo3::impl_::trampoline::cfunction_with_keywords::{{closure}}
             at /home/stijn/.cargo/registry/src/index.crates.io-6f17d22bba15001f/pyo3-0.21.2/src/impl_/trampoline.rs:45:29
  33: pyo3::impl_::trampoline::trampoline::{{closure}}
             at /home/stijn/.cargo/registry/src/index.crates.io-6f17d22bba15001f/pyo3-0.21.2/src/impl_/trampoline.rs:187:54
  34: std::panicking::try::do_call
             at /rustc/0d8b3346a3992ab11ea35ff0fb95a6864b91f797/library/std/src/panicking.rs:552:40
  35: __rust_try
  36: std::panicking::try
             at /rustc/0d8b3346a3992ab11ea35ff0fb95a6864b91f797/library/std/src/panicking.rs:516:19
  37: std::panic::catch_unwind
             at /rustc/0d8b3346a3992ab11ea35ff0fb95a6864b91f797/library/std/src/panic.rs:149:14
  38: pyo3::impl_::trampoline::trampoline
             at /home/stijn/.cargo/registry/src/index.crates.io-6f17d22bba15001f/pyo3-0.21.2/src/impl_/trampoline.rs:187:9
  39: pyo3::impl_::trampoline::cfunction_with_keywords
             at /home/stijn/.cargo/registry/src/index.crates.io-6f17d22bba15001f/pyo3-0.21.2/src/impl_/trampoline.rs:45:13
  40: polars::series::comparison::_::__INVENTORY::trampoline
             at ./src/series/comparison.rs:7:1
  41: cfunction_call
             at /tmp/python-build.20240306124936.4980/Python-3.12.2/Objects/methodobject.c:537:18
  42: _PyObject_MakeTpCall
             at /tmp/python-build.20240306124936.4980/Python-3.12.2/Objects/call.c:240:18
  43: _PyEval_EvalFrameDefault
             at /tmp/python-build.20240306124936.4980/Python-3.12.2/Python/bytecodes.c:2706:19
  44: _PyEval_EvalFrame
             at /tmp/python-build.20240306124936.4980/Python-3.12.2/./Include/internal/pycore_ceval.h:89:16
  45: _PyEval_Vector
             at /tmp/python-build.20240306124936.4980/Python-3.12.2/Python/ceval.c:1683:12
  46: PyEval_EvalCode
             at /tmp/python-build.20240306124936.4980/Python-3.12.2/Python/ceval.c:578:21
  47: run_eval_code_obj
             at /tmp/python-build.20240306124936.4980/Python-3.12.2/Python/pythonrun.c:1722:9
  48: run_mod
             at /tmp/python-build.20240306124936.4980/Python-3.12.2/Python/pythonrun.c:1743:19
  49: pyrun_file
             at /tmp/python-build.20240306124936.4980/Python-3.12.2/Python/pythonrun.c:1643:15
  50: _PyRun_SimpleFileObject
             at /tmp/python-build.20240306124936.4980/Python-3.12.2/Python/pythonrun.c:433:13
  51: _PyRun_AnyFileObject
             at /tmp/python-build.20240306124936.4980/Python-3.12.2/Python/pythonrun.c:78:15
  52: pymain_run_file_obj
             at /tmp/python-build.20240306124936.4980/Python-3.12.2/Modules/main.c:360:15
  53: pymain_run_file
             at /tmp/python-build.20240306124936.4980/Python-3.12.2/Modules/main.c:379:15
  54: pymain_run_python
             at /tmp/python-build.20240306124936.4980/Python-3.12.2/Modules/main.c:629:21
  55: Py_RunMain
             at /tmp/python-build.20240306124936.4980/Python-3.12.2/Modules/main.c:709:5
  56: pymain_main
             at /tmp/python-build.20240306124936.4980/Python-3.12.2/Modules/main.c:739:12
  57: Py_BytesMain
             at /tmp/python-build.20240306124936.4980/Python-3.12.2/Modules/main.c:763:12
  58: <unknown>
  59: __libc_start_main
  60: _start
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.
Traceback (most recent call last):
  File "/home/stijn/code/polars/py-polars/repro.py", line 6, in <module>
    result = s.eq(s)
             ^^^^^^^
  File "/home/stijn/code/polars/py-polars/polars/series/series.py", line 857, in eq
    return self.__eq__(other)
           ^^^^^^^^^^^^^^^^^^
  File "/home/stijn/code/polars/py-polars/polars/series/series.py", line 759, in __eq__
    return self._comp(other, "eq")
           ^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/stijn/code/polars/py-polars/polars/series/series.py", line 739, in _comp
    return self._from_pyseries(getattr(self._s, op)(other._s))
                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
pyo3_runtime.PanicException: called `Option::unwrap()` on a `None` value

Issue description

Equality operation between series of the same type should always work. In this case, it panics.

Expected behavior

Should work (return an empty bool series).

Installed versions

main

@stinodego stinodego added bug Something isn't working python Related to Python Polars needs triage Awaiting prioritization by a maintainer P-low Priority: low A-ops Area: operations A-dtype-categorical Area: categorical data type P-medium Priority: medium and removed needs triage Awaiting prioritization by a maintainer A-ops Area: operations P-low Priority: low labels May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-dtype-categorical Area: categorical data type bug Something isn't working P-medium Priority: medium python Related to Python Polars
Projects
Status: Ready
Development

No branches or pull requests

1 participant