fix(python): Address overly-permissive expand_selectors function, minor fixes
#16250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-beedie
requested review from
ritchie46,
stinodego,
c-peters,
MarcoGorelli and
reswqa
as code owners
alexander-beedie
force-pushed
the
fix-selector-check
branch
from
bc524aa
to
d7ba740
Compare
alexander-beedie
force-pushed
the
fix-selector-check
branch
from
d7ba740
to
e0a22f4
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16250 +/- ##
==========================================
+ Coverage 80.83% 80.88% +0.05%
==========================================
Files 1394 1393 -1
Lines 180095 179167 -928
Branches 2913 2913
==========================================
- Hits 145577 144922 -655
+ Misses 34015 33743 -272
+ Partials 503 502 -1 ☔ View full report in Codecov by Sentry. |
alexander-beedie
force-pushed
the
fix-selector-check
branch
from
e5c19f3
to
0d1a563
Compare
alexander-beedie
changed the title
expand_selectors functionexpand_selectors function, minor fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16242 (ref: #16242 (comment)).
Fixes incomplete validation in
is_selector, taking care ofexpand_selectorin the process (it should have been raising a TypeError on non-selector input). Now that it's fixed, can useis_selectorinside_selector_proxy_(in retrospect it was a bit of a red flag that we couldn't already do this ;p)Also:
__sub__and__rsub__.as_exprusage.__all__.