fix: `rolling_*_by was throwing incorrect error when dataframe was sorted by contained multiple chunks #16247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
fix
MarcoGorelli
commented
May 15, 2024
| @@ -82,6 +82,7 @@ where | |||
| return Ok(Series::new_empty(ca.name(), ca.dtype())); | |||
| } | |||
| let ca = ca.rechunk(); | |||
| let by = by.rechunk(); | |||
There was a problem hiding this comment.
The error comes from L112
let by_values = by.cont_slice().map_err(|_| {
polars_err!(
ComputeError:
"`by` column should not have null values in 'rolling by' expression"
)
})?;The values already get re-chunked, so the by ones probably should too?
…rted by contained multiple chunks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #16247 +/- ##
==========================================
- Coverage 81.04% 80.86% -0.18%
==========================================
Files 1392 1394 +2
Lines 178931 179489 +558
Branches 2907 2913 +6
==========================================
+ Hits 145014 145145 +131
- Misses 33411 33841 +430
+ Partials 506 503 -3 ☔ View full report in Codecov by Sentry. |
MarcoGorelli
requested review from
ritchie46,
stinodego,
c-peters,
alexander-beedie,
reswqa and
orlp
as code owners
ritchie46
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #16246